Skip to content

Disable NJulianRuleTest on Android #73030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarekgh merged 3 commits into from
Jul 29, 2022
Merged

Disable NJulianRuleTest on Android #73030

tarekgh merged 3 commits into from
Jul 29, 2022

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 28, 2022

Fixes #72995

@ghost
Copy link

ghost commented Jul 28, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned tarekgh Jul 28, 2022
@tarekgh tarekgh requested a review from eerhardt July 28, 2022 23:07
@tarekgh tarekgh added this to the 7.0.0 milestone Jul 28, 2022
@ghost
Copy link

ghost commented Jul 28, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #72995

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Runtime
Milestone: 7.0.0

@tarekgh tarekgh mentioned this pull request Jul 28, 2022
Closed
eerhardt
eerhardt reviewed Jul 28, 2022
View reviewed changes
@tarekgh tarekgh mentioned this pull request Jul 28, 2022
Open
ilonatommy
ilonatommy previously requested changes Jul 29, 2022
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still fails with the same error, so disabling was not effective:
image
see: runtime-staging, inside the Tests. Green tick is misleading, it does not guarantee passing tests, only indicates that the build passed.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 29, 2022
ilonatommy
ilonatommy reviewed Jul 29, 2022
View reviewed changes
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 29, 2022
@tarekgh
Copy link
Member Author

tarekgh commented Jul 29, 2022

Looks @ilonatommy using PlatformDetection.IsLinuxBionic did the trick. Now the test is not failing in the staging build.

@tarekgh tarekgh closed this Jul 29, 2022
@tarekgh tarekgh reopened this Jul 29, 2022
@tarekgh
Copy link
Member Author

tarekgh commented Jul 29, 2022

@ilonatommy can you remove the change request and merge. The PR is blocked by that.

@eerhardt eerhardt requested a review from ilonatommy July 29, 2022 19:06
@eerhardt eerhardt dismissed ilonatommy’s stale review July 29, 2022 19:07

Issue was addressed.

@tarekgh tarekgh merged commit d30ab11 into dotnet:main Jul 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MattGal MattGal MattGal left review comments

@eerhardt eerhardt eerhardt left review comments

@ilonatommy ilonatommy Awaiting requested review from ilonatommy

+1 more reviewer

@dakersnar dakersnar dakersnar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tarekgh tarekgh

Labels

area-System.Runtime

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[LinuxBionic][CI] System.Tests.TimeZoneInfoTests.NJulianRuleTest failing

5 participants

@tarekgh @MattGal @eerhardt @dakersnar @ilonatommy