Skip to content

Conversation

@marek-safar
Copy link
Contributor

with trimming on platforms where it's always false

@ghost
Copy link

ghost commented Jul 25, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

with trimming on platforms where it's always false

Author: marek-safar
Assignees: -
Labels:

area-System.Runtime.CompilerServices

Milestone: -

@MichalStrehovsky
Copy link
Member

Is there a rule for when we use substitution and when ifdef (IsDynamicCodeCompiled is a substitution)?

@marek-safar
Copy link
Contributor Author

For me substitutions are more suitable for logic that is optional

@MichalStrehovsky
Copy link
Member

Is the substitution for this still needed then?

<linker>
<assembly fullname="System.Private.CoreLib">
<type fullname="System.Runtime.CompilerServices.RuntimeFeature">
<method signature="System.Boolean get_IsDynamicCodeCompiled()" body="stub" value="false" />
</type>
</assembly>
</linker>

<type fullname="System.Runtime.CompilerServices.RuntimeFeature">
<method signature="System.Boolean get_IsDynamicCodeCompiled()" body="stub" value="false" />
</type>

@steveisok steveisok self-requested a review November 15, 2022 16:20
marek-safar and others added 3 commits November 15, 2022 13:11
with trimming on platforms where it's always false
…vices/RuntimeFeature.Mono.cs

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
@steveisok
Copy link
Member

@marek-safar do you think we still needs this?

@eerhardt
Copy link
Member

Closing, as this PR is stale and conflicts with #80246.

One comment I have here is that we run the ILLinker on CoreLib during dotnet/runtime's build. So the substitutions are made into the IL in the shipped assemblies already. I'm not sure there is an externally visible difference with this change.

@eerhardt eerhardt closed this Feb 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants