Skip to content

[Android] Port getifaddrs implementation from Xamarin.Android #71943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 5 commits into from
Jul 12, 2022
Merged

[Android] Port getifaddrs implementation from Xamarin.Android #71943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6b2c47
Port getifaddrs implementation from monodroid
simonrozsival Jul 11, 2022
4813191
Fix usage of TARGET_ANDROID
simonrozsival Jul 11, 2022
72e34be
Disable debug logs by default
simonrozsival Jul 11, 2022
9993feb
Fix checking for debug
simonrozsival Jul 11, 2022
f89b38c
Fix build error related to __VA_ARGS__
simonrozsival Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/mono/cmake/config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,6 @@
/* Have getifaddrs */
#cmakedefine HAVE_GETIFADDRS 1
Copy link
Member

@akoeplinger akoeplinger Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonrozsival we can also remove this one, it is unused in mono now

Copy link
Member Author

@simonrozsival simonrozsival Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAVE_GETIFADDRS is still used, for example here: https://github.com/dotnet/runtime/pull/71943/files#diff-404dd4500e99144ae93b6753065902099e05f7fc7ef19834d0d6e152ed0e6b45R253

Copy link
Member

@akoeplinger akoeplinger Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonrozsival that is part of System.Native, not mono. It has its own check:

runtime/src/native/libs/configure.cmake

Lines 139 to 141 in f249dc7

check_function_exists(
getifaddrs
HAVE_GETIFADDRS)


/* Have struct ifaddrs */
#cmakedefine HAVE_IFADDRS 1

/* Have access */
#cmakedefine HAVE_ACCESS 1

Expand Down
1 change: 0 additions & 1 deletion src/native/libs/Common/pal_config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#cmakedefine01 HAVE_F_FULLFSYNC
#cmakedefine01 HAVE_O_CLOEXEC
#cmakedefine01 HAVE_GETIFADDRS
#cmakedefine01 HAVE_IFADDRS
#cmakedefine01 HAVE_UTSNAME_DOMAINNAME
#cmakedefine01 HAVE_STAT64
#cmakedefine01 HAVE_FORK
Expand Down
5 changes: 5 additions & 0 deletions src/native/libs/System.Native/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ include(${CMAKE_CURRENT_LIST_DIR}/extra_libs.cmake)
set(NATIVE_LIBS_EXTRA)
append_extra_system_libs(NATIVE_LIBS_EXTRA)

if (CLR_CMAKE_TARGET_ANDROID)
list (APPEND NATIVE_LIBS_EXTRA -llog)
list (APPEND NATIVE_SOURCES pal_ifaddrs.c)
endif ()

if (GEN_SHARED_LIB)
add_library(System.Native
SHARED
Expand Down
Loading