Use llvm-objcopy for regular and cross builds #71446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables using llvm-objcopy instead of the gnu objcopy for building runtime. The benefit for cross build is that the host machine no longer needs to have cross-architecture gnu objcopy installed. There was an attempt to enable llvm objcopy in the past, but it was reverted due to a problem with objcopy in llvm 9 that incorrectly didn't strip debug symbols when `--strip-unneeded` option was specified. I have fixed that by adding `--strip-debug` in addition to the`--strip-unneeded`.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
reviewed
Jun 29, 2022
jkotas
approved these changes
Jun 29, 2022
am11
reviewed
Jun 29, 2022
am11
approved these changes
Jun 29, 2022
Member
am11
left a comment
am11
left a comment
There was a problem hiding this comment.
Thank you! Now the unstrip->strip roundtrip will work with singlefilehost as well.
This was referenced Jun 30, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables using
llvm-objcopyinstead of the gnuobjcopyforbuilding runtime. The benefit for cross build is that the host machine
no longer needs to have cross-architecture gnu
objcopyinstalled.There was an attempt to enable
llvm-objcopyin the past, but it wasreverted due to a problem with
objcopyin llvm 9 that incorrectlydidn't strip debug symbols when
--strip-unneededoption was specified.I have fixed that by adding
--strip-debugin addition to the--strip-unneeded.