Skip to content

Conversation

@steveisok
Copy link
Member

#70970 was merged with a field that was unused. This PR removes it.

dotnet#70970 was merged with a field that was unused.  This PR removes it.
@steveisok steveisok requested a review from marek-safar as a code owner June 23, 2022 12:30
@ghost ghost assigned steveisok Jun 23, 2022
@ghost
Copy link

ghost commented Jun 23, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@steveisok steveisok requested a review from akoeplinger June 23, 2022 12:30
@marek-safar
Copy link
Contributor

@stephentoub wondering why CA1823 didn't catch it

@stephentoub
Copy link
Member

stephentoub commented Jun 23, 2022

wondering why CA1823 didn't catch it

Because it's on a type explicitly attributed with [StructLayout(LayoutKind.Sequential)] and the rule explicitly avoids warning about fields on such types, as even if they're not referenced explicitly, removing them would potentially impact well-defined offsets.

@stephentoub stephentoub merged commit ade0b21 into dotnet:main Jun 29, 2022
@akoeplinger akoeplinger deleted the remove-unneeded-member branch July 11, 2022 18:01
@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants