Skip to content

JIT: arm64 osr funclet frame probing #70916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyAyersMS merged 2 commits into from
Jun 23, 2022
Merged

JIT: arm64 osr funclet frame probing #70916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b8006f
JIT: arm64 osr funclet frame probing
AndyAyersMS Jun 17, 2022
cdb3054
support frame type 5
AndyAyersMS Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/coreclr/jit/codegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,10 +1377,12 @@ void CodeGen::genFuncletProlog(BasicBlock* block)

if (genFuncletInfo.fiFrameType == 1)
{
// With OSR we may see large values for fiSpDelta1
// (we really need to probe the frame, sigh)
if (compiler->opts.IsOSR())
{
// With OSR we may see large values for fiSpDelta1.
// We repurpose genAllocLclFram to do the necessary probing.
bool scratchRegIsZero = false;
genAllocLclFrame(-genFuncletInfo.fiSpDelta1, REG_SCRATCH, &scratchRegIsZero, maskArgRegsLiveIn);
genStackPointerAdjustment(genFuncletInfo.fiSpDelta1, REG_SCRATCH, nullptr, /* reportUnwindData */ true);
GetEmitter()->emitIns_R_R_R_I(INS_stp, EA_PTRSIZE, REG_FP, REG_LR, REG_SPBASE, 0);
compiler->unwindSaveRegPair(REG_FP, REG_LR, 0);
Expand Down Expand Up @@ -1416,10 +1418,12 @@ void CodeGen::genFuncletProlog(BasicBlock* block)
}
else if (genFuncletInfo.fiFrameType == 3)
{
// With OSR we may see large values for fiSpDelta1
// (we really need to probe the frame, sigh)
if (compiler->opts.IsOSR())
{
// With OSR we may see large values for fiSpDelta1
// We repurpose genAllocLclFram to do the necessary probing.
bool scratchRegIsZero = false;
genAllocLclFrame(-genFuncletInfo.fiSpDelta1, REG_SCRATCH, &scratchRegIsZero, maskArgRegsLiveIn);
genStackPointerAdjustment(genFuncletInfo.fiSpDelta1, REG_SCRATCH, nullptr, /* reportUnwindData */ true);
GetEmitter()->emitIns_R_R_R_I(INS_stp, EA_PTRSIZE, REG_FP, REG_LR, REG_SPBASE, 0);
compiler->unwindSaveRegPair(REG_FP, REG_LR, 0);
Expand Down Expand Up @@ -1450,6 +1454,10 @@ void CodeGen::genFuncletProlog(BasicBlock* block)

if (compiler->opts.IsOSR())
{
// With OSR we may see large values for fiSpDelta1.
// We repurpose genAllocLclFram to do the necessary probing.
bool scratchRegIsZero = false;
genAllocLclFrame(-genFuncletInfo.fiSpDelta1, REG_SCRATCH, &scratchRegIsZero, maskArgRegsLiveIn);
genStackPointerAdjustment(genFuncletInfo.fiSpDelta1, REG_SCRATCH, nullptr, /* reportUnwindData */ true);
}
else
Expand Down