Skip to content

Conversation

@omajid
Copy link
Member

@omajid omajid commented Jun 17, 2022

init-distro-id.sh generates incorrect DistroRid on Alpine. While the expected DistroRid (alpine-x.xx-xxx) should only include macro version, init-distro-id.sh includes the micro version. This patches it to cut off the trailing subversion off of VERSION_ID by treating it the same way RHEL's VERSION_ID is treated.

Made as part of Alpine Linux dotnet31 / dotnet5 packaging project, see dotnet/source-build#2695

Backport of #62942

cc @agocke @ayakael @bartonjs @crummel @ericstj @hoyosjs

@ghost
Copy link

ghost commented Jun 17, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 17, 2022
@danmoseley
Copy link
Member

Are we still planning to take this? If so, we should do a template and take to tactics. If not, or paused, we should close this PR.

@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

init-distro-id.sh generates incorrect DistroRid on Alpine. While the expected DistroRid (alpine-x.xx-xxx) should only include macro version, init-distro-id.sh includes the micro version. This patches it to cut off the trailing subversion off of VERSION_ID by treating it the same way RHEL's VERSION_ID is treated.

Made as part of Alpine Linux dotnet31 / dotnet5 packaging project, see dotnet/source-build#2695

Backport of #62942

cc @agocke @ayakael @bartonjs @crummel @ericstj @hoyosjs

Author: omajid
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

@ViktorHofer ViktorHofer requested a review from am11 July 19, 2022 15:51
@carlossanlop carlossanlop requested a review from wfurt August 11, 2022 20:30
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
based on fact it is already in main.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Tactics approval needed (infra change only).
No CI failures.
Area owner signed off.
No OOB package authoring needed.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit e17718b into dotnet:release/6.0 Aug 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants