Skip to content

JIT: Enable JitConsumeProfileForCasts by default #69869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 6 commits into from
Jun 14, 2022
Merged

JIT: Enable JitConsumeProfileForCasts by default #69869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1a0e6c
Enable JitConsumeProfileForCasts by default
EgorBo May 26, 2022
d33bedb
Merge branch 'main' of https://github.com/dotnet/runtime into use-pgo…
EgorBo May 29, 2022
1a97f7b
Merge branch 'main' of github.com:dotnet/runtime into use-pgo-isinst
EgorBo Jun 13, 2022
1682f72
Fix failing tests
EgorBo Jun 13, 2022
f3ccb3e
Update CastHelpers.cs
EgorBo Jun 14, 2022
e645a98
Update CastHelpers.cs
EgorBo Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/CastHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,12 @@ private static CastResult TryGet(nuint source, nuint target)
private static object? ChkCastClassSpecial(void* toTypeHnd, object obj)
{
MethodTable* mt = RuntimeHelpers.GetMethodTable(obj);
Debug.Assert(mt != toTypeHnd, "The check for the trivial cases should be inlined by the JIT");

// Normally, this case is expected to be handled by JIT inline.
// However, with PGO data JIT might decide to check a different type instead
// so this one has to be always checked here
if (toTypeHnd == mt)
goto done;

for (; ; )
{
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/jitconfigvalues.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ CONFIG_INTEGER(JitMinimalJitProfiling, W("JitMinimalJitProfiling"), 1)
CONFIG_INTEGER(JitMinimalPrejitProfiling, W("JitMinimalPrejitProfiling"), 0)

CONFIG_INTEGER(JitProfileCasts, W("JitProfileCasts"), 0) // Profile castclass/isinst
CONFIG_INTEGER(JitConsumeProfileForCasts, W("JitConsumeProfileForCasts"), 0) // Consume profile data (if any) for
CONFIG_INTEGER(JitConsumeProfileForCasts, W("JitConsumeProfileForCasts"), 1) // Consume profile data (if any) for
// castclass/isinst

CONFIG_INTEGER(JitClassProfiling, W("JitClassProfiling"), 1) // Profile virtual and interface calls
Expand Down