Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 28, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20220502.2
  • Date Produced: May 2, 2022 7:52:17 PM UTC
  • Commit: 05a3b652d525acaac1307221b62db979d0108692
  • Branch: refs/heads/main

…427.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22227.1
@ghost ghost added the area-codeflow for labeling automated codeflow label Apr 28, 2022
…428.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22228.1
…429.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22229.2
@marek-safar
Copy link
Contributor

@vitek-karas could you look into a new error?

@vitek-karas
Copy link
Member

This is analyzer failure on ILGenerator.cs:1140 (and others) the code pattern looks like this:

private const string ConsoleTypeFullName = "System.Console, System.Console";

private void Method()
{
    Type.GetType(ConsoleTypeFullName, throwOnError: true); // IL2057
}

In linker this doesn't happen because the const field is effectively "inlined" into the IL by the compiler, so linker sees a constant string value and can resolve it. But analyzer apparently doesn't.

I'll look a bit more into this if the analyzer could figure this out, if not easily we will just suppress it for now and probably change the analyzer to not produce a warning in this case (ignore the problem).

@vitek-karas
Copy link
Member

dotnet/linker#2774 - this will teach the analyzer to recognize const fields and improve data flow tracking in such cases.

@vitek-karas
Copy link
Member

The fix on the analyzer side has been merged. Waiting for DARC to pick it up once a new build is available.

…502.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22252.2
@tannergooding
Copy link
Member

This should unblock #68612

@tannergooding
Copy link
Member

Is Maestro auto-merge tracking the skipped checks as failures?

@vitek-karas
Copy link
Member

I will merge this and take the maestro issue offline with the right people.

@vitek-karas vitek-karas merged commit 39a7960 into main May 4, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-6f4b5562-6446-438a-9cad-5cf87b9e7098 branch May 4, 2022 07:44
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants