-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[main] Update dependencies from dotnet/linker #68650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/linker #68650
Conversation
…427.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22227.1
…428.1 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22228.1
…429.2 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22229.2
|
@vitek-karas could you look into a new error? |
|
This is analyzer failure on ILGenerator.cs:1140 (and others) the code pattern looks like this: private const string ConsoleTypeFullName = "System.Console, System.Console";
private void Method()
{
Type.GetType(ConsoleTypeFullName, throwOnError: true); // IL2057
}In linker this doesn't happen because the const field is effectively "inlined" into the IL by the compiler, so linker sees a constant string value and can resolve it. But analyzer apparently doesn't. I'll look a bit more into this if the analyzer could figure this out, if not easily we will just suppress it for now and probably change the analyzer to not produce a warning in this case (ignore the problem). |
|
dotnet/linker#2774 - this will teach the analyzer to recognize const fields and improve data flow tracking in such cases. |
|
The fix on the analyzer side has been merged. Waiting for DARC to pick it up once a new build is available. |
…502.2 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22226.3 -> To Version 7.0.100-1.22252.2
|
This should unblock #68612 |
|
Is |
|
I will merge this and take the maestro issue offline with the right people. |
This pull request updates the following dependencies
From https://github.com/dotnet/linker