Fix JIT using too wide indirections when returning small structs #68160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT |
EgorBo
reviewed
Apr 18, 2022
src/tests/JIT/Regression/JitBlue/Runtime_58874/Runtime_58874.cs
Outdated
Show resolved
Hide resolved
EgorBo
approved these changes
Apr 18, 2022
Tornhoof
reviewed
Apr 18, 2022
| GenTree* retVal = ret->gtGetOp1(); | ||
| GenTree* retVal = ret->gtGetOp1(); | ||
| var_types nativeReturnType = comp->info.compRetNativeType; | ||
| // Note: small types are returned as INT. |
Contributor
There was a problem hiding this comment.
Is that comment still correct with your changes?
Member
There was a problem hiding this comment.
should be still relevant, the following genActualType should upscale all small-types to int
Member
Author
There was a problem hiding this comment.
Right, there are two nodes here, the return and the operand of the return. The return is still wide but the bug was that we were retyping the operand to a wider type, which is wrong.
Member
Author
|
Failure is dotnet/arcade#9088 |
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2206848351 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #58874
Fix #64802
Fix #68157
We should backport this given the two customer reports.