Skip to content

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Feb 25, 2022

contributes to #52362.
Aside from DummyTcpServer using APM & IAsyncResult that are pain to debug there some other issue:

When Disposing the server only stops the listener. So we can still have tests running after the test is finished. Related to that (and even more problematic) is fact that we don't have visibility to server failures. So when something fails we get

System.IO.IOException :  Received an unexpected EOF or 0 bytes from the transport stream.

that is really hard to troubleshoot for random CI failures.
Since we already have helper function to get connected stream I switched to that and we await for the server parts as well to have better visibility to failures.

@wfurt wfurt added area-System.Net.Security test-enhancement Improvements of test source code labels Feb 25, 2022
@wfurt wfurt requested review from a team and rzikm February 25, 2022 02:55
@wfurt wfurt self-assigned this Feb 25, 2022
@ghost
Copy link

ghost commented Feb 25, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #52362.
Aside from DummyTcpServer using APM & IAsyncResult that are pain to debug there some other issue:

When Disposing the server only stops the listener. So we can still have tests running after the test is finished. Related to that (and even more problematic) is fact that we don't have visibility to server failures. So when something fails we get

System.IO.IOException :  Received an unexpected EOF or 0 bytes from the transport stream.

that is really hard to troubleshoot for random CI failures.
Since we already have helper function to get connected stream I switched to that and we await for the server parts as well to have better visibility to failures.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, test enhancement

Milestone: -

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I have 2 comments.

@wfurt wfurt merged commit 654a574 into dotnet:main Mar 4, 2022
@wfurt wfurt deleted the tcpDummy branch March 4, 2022 04:15
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2022
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net.Security test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants