Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Feb 20, 2022

This path does not compile (dead code), and it has a bug: ASSIGN_FP_REG requires two arguments while one is passed at call sites.

Ref:#63596 (comment)

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-PAL-coreclr and removed community-contribution Indicates that the PR has been added by a community member labels Feb 20, 2022
@jkotas jkotas requested a review from janvorli February 20, 2022 05:54
@am11 am11 force-pushed the feature/cleanups/pal branch from 05f964e to 6a15696 Compare February 20, 2022 12:00
@am11
Copy link
Member Author

am11 commented Mar 30, 2022

@janvorli, could you please take a look?

@janvorli
Copy link
Member

Oh, I am sorry, I've completely missed this somehow.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@danmoseley danmoseley merged commit 90f7eca into dotnet:main Apr 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants