Include IsNetCoreAppRef in assembly version calculation for servicing #65166
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThis is the long term fix for: #65018 This new pattern of experimental ref only projects where the implementation is inbox, needs to be considered as an assembly in the targeting pack, so we should not bump the assembly version on servicing, with this we make sure that we catch such cases and not bump the assembly version for these experimental ref only nuget packages. The fix to release/6.0 will be ported as part of: #64556 as it is adding another ref only nuget package and needs to include it to unblock it's tests, however, we still need to have a PR created into release/6.0 to make sure we build
|
|
@safern, does this need to be backported to .NET 6? |
|
This was included in your change that added the InteropServices internal package. We just need to put up a PR for System.Runtime.Experimental to bump the servicing version and set GeneratePackageOnBuild=true. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
This is the long term fix for: #65018
This new pattern of experimental ref only projects where the implementation is inbox, needs to be considered as an assembly in the targeting pack, so we should not bump the assembly version on servicing, with this we make sure that we catch such cases and not bump the assembly version for these experimental ref only nuget packages.
The fix to release/6.0 will be ported as part of: #64556 as it is adding another ref only nuget package and needs to include it to unblock it's tests, however, we still need to have a PR created into release/6.0 to make sure we build
System.Runtime.ExperimentalwithServicingVersionset to2andGeneratePackageOnBuildset totrue.