Update StyleCopAnalyzers to 1.2.0-beta.406

eng/Versions.props

@@ -94,7 +94,7 @@
     <MicrosoftBclAsyncInterfacesVersion>5.0.0</MicrosoftBclAsyncInterfacesVersion>
     <MicrosoftWin32PrimitivesVersion>4.3.0</MicrosoftWin32PrimitivesVersion>
     <MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
-    <StyleCopAnalyzersVersion>1.2.0-beta.304</StyleCopAnalyzersVersion>
+    <StyleCopAnalyzersVersion>1.2.0-beta.406</StyleCopAnalyzersVersion>
     <SystemBuffersVersion>4.5.1</SystemBuffersVersion>
     <SystemCollectionsVersion>4.3.0</SystemCollectionsVersion>
     <SystemCollectionsImmutableVersion>5.0.0</SystemCollectionsImmutableVersion>

src/coreclr/System.Private.CoreLib/src/System/Runtime/JitInfo.CoreCLR.cs

@@ -31,4 +31,4 @@ public static partial class JitInfo
         [MethodImpl(MethodImplOptions.InternalCall)]
         private static extern long GetCompilationTimeInTicks(bool currentThread = false);
     }
-}
+}

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/JitInfo.CoreRT.cs

@@ -11,4 +11,4 @@ public static partial class JitInfo
 
         private static long GetCompilationTimeInTicks(bool currentThread = false) => 0;
     }
-}
+}

src/coreclr/nativeaot/Test.CoreLib/src/Internal/Runtime/IDynamicInterfaceCastableSupport.cs

@@ -21,4 +21,4 @@ internal static IntPtr IDynamicCastableGetInterfaceImplementation(object instanc
             return default;
         }
     }
-}
+}

src/coreclr/scripts/genRuntimeEventSources.py

@@ -400,7 +400,7 @@ def generateEventSources(manifestFullPath, intermediatesDirFullPath, runtimeFlav
             decreaseTabLevel()
             writeOutput(outputFile, "}\n")
             decreaseTabLevel()
-            writeOutput(outputFile, "}")
+            writeOutput(outputFile, "}\n")
 
 def main(argv):
 

src/coreclr/tools/Common/TypeSystem/Common/NotFoundBehavior.cs

@@ -9,4 +9,4 @@ public enum NotFoundBehavior
         ReturnNull,
         ReturnResolutionFailure
     }
-}
+}

src/installer/managed/Microsoft.NET.HostModel/HostModelUtils.cs

@@ -33,4 +33,4 @@ public static (int ExitCode, string StdErr) RunCodesign(string args, string appH
             }
         }
     }
-}
+}

src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs

@@ -29,4 +29,4 @@ public static bool CheckHasDefaultValue(ParameterInfo parameter, out bool tryToG
             }
         }
     }
-}
+}

src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetEnv.cs

@@ -11,4 +11,4 @@ internal unsafe partial class Sys
         [GeneratedDllImport(Interop.Libraries.SystemNative, CharSet = CharSet.Ansi, EntryPoint = "SystemNative_GetEnv")]
         internal static unsafe partial IntPtr GetEnv(string name);
     }
-}
+}

src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetEnviron.cs

@@ -14,4 +14,4 @@ internal unsafe partial class Sys
         [GeneratedDllImport(Interop.Libraries.SystemNative, EntryPoint = "SystemNative_FreeEnviron")]
         internal static unsafe partial void FreeEnviron(IntPtr environ);
     }
-}
+}

src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CertControlStoreFlags.cs

@@ -13,4 +13,4 @@ internal enum CertControlStoreFlags : int
             None = 0x00000000,
         }
     }
-}
+}

src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CertControlStoreType.cs

@@ -10,4 +10,4 @@ internal enum CertControlStoreType : int
             CERT_STORE_CTRL_AUTO_RESYNC = 4,
         }
     }
-}
+}

src/libraries/Microsoft.Extensions.Hosting/src/ValidationHostedService.cs

@@ -54,4 +54,4 @@ public Task StartAsync(CancellationToken cancellationToken)
 
         public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivityStatusCode.cs

@@ -23,4 +23,4 @@ public enum ActivityStatusCode
         /// </summary>
         Error = 2
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagLinkedList.cs

@@ -189,4 +189,4 @@ public void Dispose()
         }
     }
 
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Counter.cs

@@ -74,4 +74,4 @@ internal Counter(Meter meter, string name, string? unit, string? description) :
         /// <param name="tagList">A <see cref="T:System.Diagnostics.TagList" /> of tags associated with the measurement.</param>
         public void Add(T delta, in TagList tagList) => RecordMeasurement(delta, in tagList);
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Histogram.cs

@@ -74,4 +74,4 @@ internal Histogram(Meter meter, string name, string? unit, string? description)
         /// <param name="tagList">A <see cref="T:System.Diagnostics.TagList" /> of tags associated with the measurement.</param>
         public void Record(T value, in TagList tagList) => RecordMeasurement(value, in tagList);
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Instrument.common.cs

@@ -47,4 +47,4 @@ protected void RecordMeasurement(T measurement, ReadOnlySpan<KeyValuePair<string
             }
         }
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Instrument.netcore.cs

@@ -111,4 +111,4 @@ protected void RecordMeasurement(T measurement, in TagList tagList)
             RecordMeasurement(measurement, MemoryMarshal.CreateReadOnlySpan(ref Unsafe.AsRef(in tagList.Tag1), tagList.Count));
        }
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/ObservableCounter.cs

@@ -43,4 +43,4 @@ internal ObservableCounter(Meter meter, string name, Func<IEnumerable<Measuremen
         /// </summary>
         protected override IEnumerable<Measurement<T>> Observe() => Observe(_callback);
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/ObservableGauge.cs

@@ -43,4 +43,4 @@ internal ObservableGauge(Meter meter, string name, Func<IEnumerable<Measurement<
         /// </summary>
         protected override IEnumerable<Measurement<T>> Observe() => Observe(_callback);
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/ObservableUpDownCounter.cs

@@ -43,4 +43,4 @@ internal ObservableUpDownCounter(Meter meter, string name, Func<IEnumerable<Meas
         /// </summary>
         protected override IEnumerable<Measurement<T>> Observe() => Observe(_callback);
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/TagList.cs

@@ -548,4 +548,4 @@ public bool MoveNext()
             public void Reset() => _index = -1;
         }
     }
-}
+}

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/UpDownCounter.cs

@@ -73,4 +73,4 @@ internal UpDownCounter(Meter meter, string name, string? unit, string? descripti
         /// <param name="tagList">A <see cref="T:System.Diagnostics.TagList" /> of tags associated with the measurement.</param>
         public void Add(T delta, in TagList tagList) => RecordMeasurement(delta, in tagList);
     }
-}
+}

src/libraries/System.Drawing.Common/src/System/Drawing/LocalAppContextSwitches.Unix.cs

@@ -13,4 +13,4 @@ public static bool EnableUnixSupport
             get => false;
         }
     }
-}
+}

src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.AnyMobile.InvokeNativeHandler.cs

@@ -157,4 +157,4 @@ private HttpMessageHandler CreateNativeHandler()
             return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
         }
     }
-}
+}

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.tvOS.cs

@@ -27,4 +27,4 @@ public static Task<HttpResponseMessage> SendWithNtConnectionAuthAsync(HttpReques
             return InnerSendAsync(request, request.RequestUri, async, credentials, isProxyAuth: false, connection, connectionPool, cancellationToken);
         }
     }
-}
+}

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Interop/MsQuicTraceHelper.cs

@@ -27,4 +27,4 @@ private static string GetIntPtrHex(SafeHandle handle)
             return handle.DangerousGetHandle().ToString("X11");
         }
     }
-}
+}

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/ThrowHelper.cs

@@ -23,4 +23,4 @@ internal static Exception GetStreamAbortedException(long errorCode)
             };
         }
     }
-}
+}

src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

@@ -365,4 +365,4 @@ private WebSocketState GetReadyState()
             };
         }
     }
-}
+}

src/libraries/System.Private.CoreLib/src/Internal/Console.Android.cs

@@ -21,4 +21,4 @@ public static unsafe void Write(string s)
             }
         }
     }
-}
+}

src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs

@@ -133,4 +133,4 @@ private void ThrowNoInvokeException()
             return retValue;
         }
     }
-}
+}

src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ObjectiveC/ObjectiveCTrackedTypeAttribute.cs

@@ -17,4 +17,4 @@ public sealed class ObjectiveCTrackedTypeAttribute : Attribute
         /// </summary>
         public ObjectiveCTrackedTypeAttribute() { }
     }
-}
+}

src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/UnmanagedCallConvAttribute.cs

@@ -22,4 +22,4 @@ public UnmanagedCallConvAttribute()
          /// </remarks>
          public Type[]? CallConvs;
      }
-}
+}

src/libraries/System.Private.CoreLib/src/System/Runtime/JitInfo.cs

@@ -20,4 +20,4 @@ public static TimeSpan GetCompilationTime(bool currentThread = false)
             return TimeSpan.FromTicks(GetCompilationTimeInTicks(currentThread));
         }
     }
-}
+}

src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Unix.Android.cs

@@ -475,4 +475,4 @@ public byte[] GetTimeZoneData(string id)
             }
         }
     }
-}
+}

src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.Utils.cs

@@ -58,4 +58,4 @@ private static int Reduce(Span<uint> bits, ReadOnlySpan<uint> modulus)
             return bits.Length;
         }
     }
-}
+}

src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs

@@ -850,4 +850,4 @@ public static explicit operator Complex(decimal value)
             return new Complex((double)value, 0.0);
         }
     }
-}
+}

src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/DSA.Create.Android.cs

@@ -10,4 +10,4 @@ private static DSA CreateCore()
             return new DSAImplementation.DSAAndroid();
         }
     }
-}
+}

src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/DSA.Create.NotSupported.cs

@@ -12,4 +12,4 @@ private static DSA CreateCore()
             throw new PlatformNotSupportedException();
         }
     }
-}
+}

src/mono/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipe.Mono.cs

@@ -90,4 +90,4 @@ internal static ulong GetRuntimeCounterValue(RuntimeCounters counterID)
         }
 #endif
     }
-}
+}

src/mono/System.Private.CoreLib/src/System/Runtime/InteropServices/ObjectiveCMarshal.Mono.cs

@@ -34,4 +34,4 @@ private static IntPtr CreateReferenceTrackingHandleInternal(
             out int memInSizeT,
             out IntPtr mem) => throw new NotImplementedException();
     }
-}
+}

src/mono/System.Private.CoreLib/src/System/Runtime/JitInfo.Mono.cs

@@ -35,4 +35,4 @@ private static long GetCompilationTimeInTicks(bool currentThread = false)
             return currentThread ? 0 : (long)EventPipeInternal.GetRuntimeCounterValue(EventPipeInternal.RuntimeCounters.JIT_TICKS_IN_JIT);
         }
     }
-}
+}

src/tasks/Crossgen2Tasks/CommonFilePulledFromSdkRepo/Logger.cs

@@ -143,4 +143,4 @@ private static void DebugThrowMissingOrIncorrectCode(string code, string message
         private static bool IsAsciiDigit(char c)
             => c >= '0' && c <= '9';
     }
-}
+}

src/tasks/Crossgen2Tasks/CommonFilePulledFromSdkRepo/MetadataKeys.cs

@@ -126,4 +126,4 @@ internal static class MetadataKeys
         public const string CreateCompositeImage = "CreateCompositeImage";
         public const string PerfmapFormatVersion = "PerfmapFormatVersion";
     }
-}
+}

src/tasks/Crossgen2Tasks/PrepareForReadyToRunCompilation.cs

@@ -502,4 +502,4 @@ private static bool HasILCode(PEReader peReader, MetadataReader mdReader)
             return false;
         }
     }
-}
+}

src/tasks/Crossgen2Tasks/ResolveReadyToRunCompilers.cs

@@ -402,4 +402,4 @@ private static string ArchitectureToString(Architecture architecture)
             };
         }
     }
-}
+}

src/tasks/Crossgen2Tasks/RunReadyToRunCompiler.cs

@@ -408,4 +408,4 @@ protected override void LogEventsFromTextOutput(string singleLine, MessageImport
             }
         }
     }
-}
+}

src/tasks/Crossgen2Tasks/ShimFilesSimulatingLogicInSdkRepo/SimpleItemUtilities.cs

@@ -37,4 +37,4 @@ public static bool HasMetadataValue(this ITaskItem item, string name, string exp
             return string.Equals(value, expectedValue, StringComparison.OrdinalIgnoreCase);
         }
     }
-}
+}

src/tasks/Crossgen2Tasks/ShimFilesSimulatingLogicInSdkRepo/Strings.cs

@@ -22,4 +22,4 @@ public static class Strings
         public static string ReadyToRunNoValidRuntimePackageError = "ReadyToRunNoValidRuntimePackageError";
         public static string ReadyToRunTargetNotSupportedError = "ReadyToRunTargetNotSupportedError";
     }
-}
+}

src/tasks/WorkloadBuildTasks/GenerateFileFromTemplate.cs

@@ -147,4 +147,4 @@ public string Replace(string template, IDictionary<string, string> values)
 
         return sb.ToString();
     }
-}
+}