Skip to content

Move IsKnownConstant handling to ExtendedDefaultPolicy #64809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 5 commits into from
Feb 17, 2022
Merged

Move IsKnownConstant handling to ExtendedDefaultPolicy #64809

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
768c53a
Fix RuntimeHelpers.IsKnownConstant for ExtendedDefaultPolicy
EgorBo Feb 4, 2022
5ff4bc7
Fix RuntimeHelpers.IsKnownConstant for ExtendedDefaultPolicy
EgorBo Feb 4, 2022
75bba73
Update inlinepolicy.cpp
EgorBo Feb 9, 2022
78189d0
Update inlinepolicy.cpp
EgorBo Feb 16, 2022
fae3f02
Merge branch 'main' of https://github.com/dotnet/runtime into fix-isc…
EgorBo Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/coreclr/jit/inlinepolicy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,15 +735,6 @@ double DefaultPolicy::DetermineMultiplier()
JITDUMP("\nInline candidate has arg that feeds range check. Multiplier increased to %g.", multiplier);
}

if (m_ConstArgFeedsIsKnownConst || (m_ArgFeedsIsKnownConst && m_IsPrejitRoot))
{
// if we use RuntimeHelpers.IsKnownConstant we most likely expect our function to be always inlined
// at least in the case of constant arguments. In IsPrejitRoot we don't have callsite info so let's
// assume we have a constant here in order to avoid "baked" noinline
multiplier += 20;
JITDUMP("\nConstant argument feeds RuntimeHelpers.IsKnownConstant. Multiplier increased to %g.", multiplier);
}

if (m_ConstantArgFeedsConstantTest > 0)
{
multiplier += 3.0;
Expand Down