Deduplicate class names under JIT/Methodical/cctor #64710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this particular class of tests deduplicating tests via namespace names is not useful as they use common modules expecting the namespaces to match. Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsIn this particular class of tests deduplicating tests via namespace names Thanks Tomas /cc @dotnet/jit-contrib
|
ghost
assigned
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this particular class of tests deduplicating tests via namespace names
(which is what my rewriting tool does by default) is not useful as they use common
modules expecting the namespaces to match. For this reason I have manually
deduplicated the class names instead. (In case of the one IL test, we can use
namespace deduplication, we just need to get rid of the super-common type
names like A or B).
Thanks
Tomas
/cc @dotnet/jit-contrib