Throw PNSE if insufficient privileges when custom Ping payload was specified #64625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #62458 I had to refactor tests a bit since they depended on the fact that such invocation would not throw.
|
wfurt
reviewed
Feb 1, 2022
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.PingUtility.cs
Outdated
Show resolved
Hide resolved
wfurt
reviewed
Feb 1, 2022
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Feb 1, 2022
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
wfurt
reviewed
Feb 1, 2022
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
wfurt
reviewed
Feb 1, 2022
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
ManickaP
reviewed
Feb 1, 2022
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
rzikm
force-pushed
the
62458_ping-PNSE
branch
from
8ad0af7 to
d906962
Compare
rzikm
force-pushed
the
62458_ping-PNSE
branch
from
d906962 to
68d3699
Compare
rzikm
force-pushed
the
62458_ping-PNSE
branch
from
6933ad6 to
2ad4d51
Compare
Member
Author
|
Test failures are unrelated |
wfurt
reviewed
Feb 3, 2022
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
wfurt
approved these changes
Feb 3, 2022
Member
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
Generally looks good to me.
I left comment about UsesPingUtility that seems wrong.
Member
Author
|
CI Failures are unrelated (failed to upload to Helix) |
karelz
added
the
breaking-change
ghost
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
2 tasks
ghost
locked as resolved and limited conversation to collaborators
rzikm
removed
the
needs-breaking-change-doc-created
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62458
I had to refactor tests a bit since they depended on the fact that such invocation would not throw.