Disable ipv6 lookup tests when needed #64313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFix #55576 See #63259 (comment) This mysterious policy was set on my machine again, so adding the necessary code to skip the 2 tests in such a case. Verified with and without the key present.
|
ghost
assigned
Member
Author
|
@wfurt, seem reasonable? |
wfurt
approved these changes
Jan 27, 2022
Member
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
I would be fine skipping the tests if any rules exist. That would not impact our CI and could work for other corporate environments as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55576
See #63259 (comment)
This mysterious policy was set on my machine again, so adding the necessary code to skip the 2 tests in such a case. Verified with and without the key present.