[wasm] Cancel pending ReadableStream on Dispose or cancelationToken #64285

pavelsavara · 2022-01-25T18:55:00Z

call ReadableStream.cancel on cancelationToken of WasmHttpReadStream.ReadAsync
call AbortController.abort when disposing WasmFetchResponse and WasmHttpReadStream
enable some of SocketsHttpHandler_HttpClientHandler_Http11_Cancellation_Test tests for Browser target
added WaitForClose to the LoopbackServer
added disconnect detection to RemoteLoopHandler
add unit test for the scenario

- add unit test for the scenario

ghost · 2022-01-25T18:55:05Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

call ReadableStream.cancel when disposing WasmHttpReadStream
call AbortController.abort when disposing WasmFetchResponse
add unit test for the scenario

Author:	pavelsavara
Assignees:	-
Labels:	`arch-wasm`, `area-System.Net.Http`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	7.0.0

pavelsavara · 2022-01-25T18:56:57Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-25T18:57:21Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/Common/tests/System/Net/Http/ResponseStreamTest.cs

danmoseley · 2022-01-25T20:18:12Z

One area- label only please, for labeler bot ..

src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs

- fixed few cancelation issues

src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs

pavelsavara · 2022-01-27T13:35:32Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-27T13:35:54Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-01-27T16:08:53Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-27T16:09:18Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs

...braries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/Handlers/RemoteLoopHandler.cs

pavelsavara · 2022-01-28T10:08:53Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-28T10:09:13Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs

…st.Cancellation.cs

lewing · 2022-01-28T19:05:41Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-28T19:06:03Z

Azure Pipelines successfully started running 1 pipeline(s).

lewing · 2022-02-17T16:38:29Z

We've had another customer report of this in net6 should we consider servicing it?

- call cancel when disposing ReadableStream

184846d

- add unit test for the scenario

pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http area-System.Runtime.InteropServices.JavaScript labels Jan 25, 2022

pavelsavara added this to the 7.0.0 milestone Jan 25, 2022

pavelsavara requested review from kg and maraf January 25, 2022 18:55

ghost assigned pavelsavara Jan 25, 2022

kg reviewed Jan 25, 2022

View reviewed changes

src/libraries/Common/tests/System/Net/Http/ResponseStreamTest.cs Outdated Show resolved Hide resolved

danmoseley removed the area-System.Runtime.InteropServices.JavaScript label Jan 25, 2022

halter73 reviewed Jan 25, 2022

View reviewed changes

src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs Outdated Show resolved Hide resolved

- enabled cancelation tests for browser

19a8182

- fixed few cancelation issues

maraf reviewed Jan 27, 2022

View reviewed changes

src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs Show resolved Hide resolved

pavelsavara added 2 commits January 27, 2022 14:08

fix

3c9b244

end to end test

3e2ed32

fix

4a95748

pavelsavara changed the title ~~[wasm] Cancel pending ReadableStream on Dispose~~ [wasm] Cancel pending ReadableStream on Dispose or cancelationToken Jan 27, 2022

revert unnecesary test change

d2d74df

marek-safar reviewed Jan 27, 2022

View reviewed changes

src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs Outdated Show resolved Hide resolved

marek-safar reviewed Jan 27, 2022

View reviewed changes

...braries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/Handlers/RemoteLoopHandler.cs Outdated Show resolved Hide resolved

feedback + netfx CI problem

c23f74f

maraf approved these changes Jan 28, 2022

View reviewed changes

src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs Outdated Show resolved Hide resolved

feedback

7508699

lewing reviewed Jan 28, 2022

View reviewed changes

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs Outdated Show resolved Hide resolved

Update src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTe…

b074484

…st.Cancellation.cs

pavelsavara merged commit 7de2905 into dotnet:main Jan 29, 2022

ghost locked as resolved and limited conversation to collaborators Mar 19, 2022

pavelsavara deleted the wasm_http_streaming_cancel branch July 14, 2022 20:45

[wasm] Cancel pending ReadableStream on Dispose or cancelationToken #64285

[wasm] Cancel pending ReadableStream on Dispose or cancelationToken #64285

Uh oh!

Conversation

pavelsavara commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 25, 2022

Uh oh!

pavelsavara commented Jan 25, 2022

Uh oh!

azure-pipelines bot commented Jan 25, 2022

Uh oh!

Uh oh!

danmoseley commented Jan 25, 2022

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Jan 27, 2022

Uh oh!

azure-pipelines bot commented Jan 27, 2022

Uh oh!

pavelsavara commented Jan 27, 2022

Uh oh!

azure-pipelines bot commented Jan 27, 2022

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Jan 28, 2022

Uh oh!

azure-pipelines bot commented Jan 28, 2022

Uh oh!

Uh oh!

Uh oh!

lewing commented Jan 28, 2022

Uh oh!

azure-pipelines bot commented Jan 28, 2022

Uh oh!

lewing commented Feb 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pavelsavara commented Jan 25, 2022 •

edited

Loading