Skip to content

Re-enable failing long path test #64113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 2 commits into from
Jan 24, 2022
Merged

Re-enable failing long path test #64113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a07555d
Re-enable path too long test
danmoseley Jan 21, 2022
07ead81
enable
danmoseley Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,16 @@ public void DirectoryLongerThanMaxLongPath_ThrowsPathTooLongException()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/64019")]
[ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))]
[PlatformSpecific(TestPlatforms.Windows)]
public void DirectoryLongerThanMaxLongPathWithExtendedSyntax_ThrowsException()
{
var paths = IOInputs.GetPathsLongerThanMaxLongPath(GetTestFilePath(), useExtendedSyntax: true);

// Ideally this should be PathTooLongException or DirectoryNotFoundException but on some machines
// windows gives us ERROR_INVALID_NAME, producing IOException.
Assert.All(paths, path =>
AssertExtensions.ThrowsAny<PathTooLongException, DirectoryNotFoundException>(() => Create(path)));
AssertExtensions.ThrowsAny<PathTooLongException, DirectoryNotFoundException, IOException>(() => Create(path)));
}

[ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))]
Expand Down