Skip to content

Retries for flaky WMI test #64008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 1 commit into from
Jan 19, 2022
Merged

Retries for flaky WMI test #64008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions src/libraries/System.Management/tests/System/Management/ManagementObjectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.IO;
using System.Runtime.Serialization.Formatters.Binary;
using Xunit;
using Xunit.Sdk;

namespace System.Management.Tests
{
Expand Down Expand Up @@ -64,28 +65,33 @@ public void Set_Property_Win32_ComputerSystem()
[OuterLoop]
public void Invoke_Instance_And_Static_Method_Win32_Process()
{
var processClass = new ManagementClass("Win32_Process");
object[] methodArgs = { "notepad.exe", null, null, 0 };
// Retries are sometimes necessary as underlying API call can return
// ERROR_NOT_READY or occasionally ERROR_INVALID_BLOCK or ERROR_NOT_ENOUGH_MEMORY
RetryHelper.Execute(() =>
{
var processClass = new ManagementClass("Win32_Process");
object[] methodArgs = { "notepad.exe", null, null, 0 };

object resultObj = processClass.InvokeMethod("Create", methodArgs);
object resultObj = processClass.InvokeMethod("Create", methodArgs);

var resultCode = (uint)resultObj;
Assert.Equal(0u, resultCode);
var resultCode = (uint)resultObj;
Assert.Equal(0u, resultCode);

var processId = (uint)methodArgs[3];
Assert.True(0u != processId, $"Unexpected process ID: {processId}");
var processId = (uint)methodArgs[3];
Assert.True(0u != processId, $"Unexpected process ID: {processId}");

using (Process targetProcess = Process.GetProcessById((int)processId))
using (var process = new ManagementObject($"Win32_Process.Handle=\"{processId}\""))
{
Assert.False(targetProcess.HasExited);
using (Process targetProcess = Process.GetProcessById((int)processId))
using (var process = new ManagementObject($"Win32_Process.Handle=\"{processId}\""))
{
Assert.False(targetProcess.HasExited);

resultObj = process.InvokeMethod("Terminate", new object[] { 0 });
resultCode = (uint)resultObj;
Assert.Equal(0u, resultCode);
resultObj = process.InvokeMethod("Terminate", new object[] { 0 });
resultCode = (uint)resultObj;
Assert.Equal(0u, resultCode);

Assert.True(targetProcess.HasExited);
}
Assert.True(targetProcess.HasExited);
}
}, maxAttempts: 10, retryWhen: e => e is XunitException);
}

[ConditionalFact(typeof(WmiTestHelper), nameof(WmiTestHelper.IsWmiSupported))]
Expand Down