Skip to content

#51371 fixed failing test in iossimulator #63877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkhamoyan merged 18 commits into from
Jan 27, 2022
Merged

#51371 fixed failing test in iossimulator #63877

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c9e82e3
#51371 fixed failing test in iossimulator
mkhamoyan Jan 17, 2022
0428831
#51371 added skiptestexception
mkhamoyan Jan 17, 2022
cfe4592
#51371 added space after reference
mkhamoyan Jan 17, 2022
4b8fe65
#51371 fixed remaining failing tests
mkhamoyan Jan 19, 2022
7a3053c
#51371 whitespace issue
mkhamoyan Jan 19, 2022
5e2771d
#51371 removed extra spaces
mkhamoyan Jan 20, 2022
4b2dfb1
Squashed commit of the following:
mkhamoyan Jan 20, 2022
69ea51e
#51371 added pipeName case for running on macos
mkhamoyan Jan 20, 2022
65daf2f
Merge branch 'main' into 51371_failing_filesystem_tests
mkhamoyan Jan 20, 2022
8696973
#51371 removed extra spaces, adjusted IsCaseSensitiveProperty and oth…
mkhamoyan Jan 20, 2022
100cac7
Merge branch '51371_failing_filesystem_tests' of https://github.com/m…
mkhamoyan Jan 20, 2022
507d239
#51371 removed extra spaces
mkhamoyan Jan 21, 2022
6154087
#51371 removed pipePath change in windows file
mkhamoyan Jan 21, 2022
d989e86
#51371 Done minor changes
mkhamoyan Jan 21, 2022
d457075
#51371 extended maxdirectory for not windows
mkhamoyan Jan 24, 2022
bdc06e9
#51371 in case of windows don't change parameter IsCaseSensitiveOS
mkhamoyan Jan 25, 2022
eddd2ca
#51371 changing maxdirectory for nonwindows
mkhamoyan Jan 25, 2022
2501ef2
#51371 removed from Pipestream the change and edited path in FileClea…
mkhamoyan Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/libraries/System.IO.FileSystem/tests/Directory/GetFileSystemEntries_str_str.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Runtime.InteropServices;
using Xunit;
using System.Linq;
using Microsoft.DotNet.XUnitExtensions;

namespace System.IO.Tests
{
Expand Down Expand Up @@ -697,11 +698,16 @@ public void WindowsSearchPatternWhitespace()
Assert.Empty(GetEntries(TestDirectory, "\t"));
}

[Fact]
[ConditionalFact]
[PlatformSpecific(CaseSensitivePlatforms)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51371", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void SearchPatternCaseSensitive()
{
if (RuntimeInformation.RuntimeIdentifier.StartsWith("iossimulator")
Copy link
Member

@steveisok steveisok Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a property to https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs and use it in the condition instead?

Copy link
Member

@akoeplinger akoeplinger Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea.

|| RuntimeInformation.RuntimeIdentifier.StartsWith("tvossimulator"))
{
throw new SkipTestException("iOS/tvOS simulators run on a macOS host and are subject to the same case sensitivity behavior.");
}

DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
string testBase = GetTestFileName();
testDir.CreateSubdirectory(testBase + "aBBb");
Expand Down
11 changes: 9 additions & 2 deletions src/libraries/System.IO.FileSystem/tests/File/Create.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Linq;
using System.Runtime.InteropServices;
using Xunit;
using Microsoft.DotNet.XUnitExtensions;

namespace System.IO.Tests
{
Expand Down Expand Up @@ -217,11 +219,16 @@ public void LongFileName()
Assert.False(File.Exists(path));
}

[Fact]
[ConditionalFact]
[PlatformSpecific(CaseSensitivePlatforms)]
Copy link
Member

@steveisok steveisok Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to expand upon CaseSensitivePlatforms?

Copy link
Contributor Author

@mkhamoyan mkhamoyan Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded IsCaseSensitiveOS.

[ActiveIssue("https://github.com/dotnet/runtime/issues/51371", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void CaseSensitive()
{
if (RuntimeInformation.RuntimeIdentifier.StartsWith("iossimulator")
|| RuntimeInformation.RuntimeIdentifier.StartsWith("tvossimulator"))
{
throw new SkipTestException("iOS/tvOS simulators run on a macOS host and are subject to the same case sensitivity behavior.");
}

DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
string testFile = Path.Combine(testDir.FullName, GetTestFileName());
using (File.Create(testFile + "AAAA"))
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/File/Exists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ public void PathWithReservedDeviceNameAsPath_ReturnsFalse(string component)

[Theory,
MemberData(nameof(UncPathsWithoutShareName))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51371", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void UncPathWithoutShareNameAsPath_ReturnsFalse(string component)
{
Assert.False(Exists(component));
Expand Down