Add more automated test coverage for the wasm bindings as prep for custom marshalers #63498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the custom marshaler system
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis pulls all the automated tests out of #47640, so it adds some new test coverage for existing code along with test coverage for a mix of doesn't-work-because-things-are-broken-now and doesn't-work-but-will-soon stuff
|
pavelsavara
reviewed
Jan 7, 2022
| } | ||
|
|
||
| [Fact] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/pull/47640")] |
Member
There was a problem hiding this comment.
Could you please create issue(s) instead of PR for all [ActiveIssue].
Ideally with good description of missing functionality.
Multiple issues if the underlying concepts are separate.
Many thanks!
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls all the automated tests out of #47640, so it adds some new test coverage for existing code along with test coverage for a mix of doesn't-work-because-things-are-broken-now and doesn't-work-but-will-soon stuff