Move init-vs-env in test build script down #63433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`init-vs-env.cmd` is going to set up the environment for x86 tools and that messes with things if they run before we run vcvarsall to set the actual target architecture, so it's better not to have such window. As an additional improvement, init-vs-env.cmd can also run vcvarsall (that we do a couple lines below where I'm moving this), and find CMake (we do that a couple lines above). I could collapse those two, but we'll lose some console logging (init-vs-env doesn't log anything it does to the console), so not sure if that's an improvement.
ghost
assigned
|
Tagging subscribers to this area: @hoyosjs Issue Details
As an additional improvement, init-vs-env.cmd can also run vcvarsall (that we do a couple lines below where I'm moving this), and find CMake (we do that a couple lines above). I could collapse those two, but we'll lose some console logging (init-vs-env doesn't log anything it does to the console), so not sure if that's an improvement.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init-vs-env.cmdis going to set up the environment for x86 tools (the "VS Developer Command Prompt") and that messes with things if they run before we run vcvarsall to set the actual target architecture, so it's better not to have such window. We might not even run the vcvarsall line if native test build is skipped.As an additional improvement, init-vs-env.cmd can also run vcvarsall and set up CMake, so I'm asking it to do it (done by passing an extra parameter to the script to specify which environment to activate).
I need this change for a subsequent change that is broken if we have x86 tools set up.