Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Dec 22, 2021

  • System.Environment.MachineName is resolved using gethostname() C library function on Unix. However, its test is using utsname.nodename. Changed test to also use GetHostName() and deleted GetNodeName().
  • TypeSpec.NeedsEscaping() is unused in mono, hence deleted.

@am11 am11 requested a review from marek-safar as a code owner December 22, 2021 22:43
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 22, 2021
@ghost
Copy link

ghost commented Dec 22, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkoritzinsky jkoritzinsky merged commit c3dd830 into dotnet:main Dec 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants