Skip to content

Conversation

@deeprobin
Copy link
Contributor

@deeprobin deeprobin commented Dec 19, 2021

Proposal implementation of #47922 (closes #47922)

Proposal

namespace System
{
    public static partial class AppContext
    {
        public static void SetData(string name, object? data);
    }
}

/cc @jkotas
/cc @tannergooding

@ghost
Copy link

ghost commented Dec 19, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Dec 19, 2021
@ghost
Copy link

ghost commented Dec 19, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas
Copy link
Member

jkotas commented Dec 19, 2021

Could you please also add a few tests and add doc comment on the implementation?

@ghost
Copy link

ghost commented Dec 19, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Proposal implementation of #47922

Proposal

namespace System
{
    public static partial class AppContext
    {
        public static void SetData(string name, object? data);
    }
}

/cc @jkotas
/cc @tannergooding

Author: deeprobin
Assignees: -
Labels:

area-System.Runtime, new-api-needs-documentation, community-contribution

Milestone: -

@danmoseley
Copy link
Member

Oh, still needs doc comment on implementation

@deeprobin
Copy link
Contributor Author

Oh, still needs doc comment on implementation

incoming :)

@deeprobin
Copy link
Contributor Author

Oh, still needs doc comment on implementation

Done.

@danmoseley I saw also, that GetData has no documentation comment (but in API Docs this is present - https://docs.microsoft.com/en-us/dotnet/api/system.appcontext.getdata?view=net-6.0)
If you want to document GetData afterwards, you can create a new issue regarding this 👍🏼

@jkotas
Copy link
Member

jkotas commented Dec 20, 2021

GetData has no documentation comment (but in API Docs this is present -

We have a dedicate project to add the documentation comments to all old APIs. No need to file an issue on this.

@deeprobin
Copy link
Contributor Author

GetData has no documentation comment (but in API Docs this is present -

We have a dedicate project to add the documentation comments to all old APIs. No need to file an issue on this.

Perfect 👍🏼

@deeprobin deeprobin requested a review from jkotas December 20, 2021 19:30
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@jkotas jkotas merged commit 6a9bfee into dotnet:main Dec 21, 2021
@deeprobin deeprobin changed the title Expose AppContext.SetData in ref assembly [API Implementation]: Expose AppContext.SetData in ref assembly Jan 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: AppContext.SetData

3 participants