-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[API Implementation]: Expose AppContext.SetData in ref assembly #62996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Could you please also add a few tests and add doc comment on the implementation? |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsProposal implementation of #47922 Proposalnamespace System
{
public static partial class AppContext
{
public static void SetData(string name, object? data);
}
}/cc @jkotas
|
|
Oh, still needs doc comment on implementation |
incoming :) |
Done. @danmoseley I saw also, that |
src/libraries/System.Runtime/tests/System/AppContext/AppContext.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <[email protected]>
We have a dedicate project to add the documentation comments to all old APIs. No need to file an issue on this. |
Perfect 👍🏼 |
src/libraries/System.Runtime/tests/System/AppContext/AppContext.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Proposal implementation of #47922 (closes #47922)
Proposal
/cc @jkotas
/cc @tannergooding