Skip to content

Use System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting #62903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 3 commits into from
Dec 25, 2021
Merged

Use System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting #62903

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16a3ae1
Move coreclr specific ComponentActivator hosting dependency to coreclr
marek-safar Dec 16, 2021
0a0132f
Revert "Move coreclr specific ComponentActivator hosting dependency t…
marek-safar Dec 21, 2021
88fc770
Use System.Runtime.InteropServices.EnableConsumingManagedCodeFromNati…
marek-safar Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@
https://github.com/mono/linker/pull/649 -->
<method name=".ctor" />
</type>
</assembly>

<!-- Native hosting accesses managed methods in the ComponentActivator class.
These are always rooted to ensure native calls get trimmer related errors
but will be trimmed away by the related feature switch -->
<assembly fullname="System.Private.CoreLib" feature="System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting" featurevalue="true">
<!-- Native hosting accesses managed methods from
https://github.com/dotnet/runtime/blob/bbc898f3e5678135b242faeb6eefd8b24bf04f3c/src/native/corehost/hostpolicy/hostpolicy.cpp#L527-L538
but ComponentActivator is not trimming safe. We persist the methods only when `_EnableConsumingManagedCodeFromNativeHosting` setting
is enabled and only then we show the trimming warnings about possibly missing dependencies.
-->
<type fullname="Internal.Runtime.InteropServices.ComponentActivator">
<method name="LoadAssemblyAndGetFunctionPointer" />
<method name="GetFunctionPointer" />
Expand Down