Improve compatibility with IL Linker #62890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<TrimmerRootAssembly Include="myEntrypointAssembly" />` won't actually root anything with IL Linker. NativeAOT would do what it's instructed to do. This is showing up as a difference because the SDK auto-injects this root into all trimmed projects.
MichalStrehovsky
added
area-NativeAOT-coreclr
and removed
area-crossgen2-coreclr
labels
jkotas
approved these changes
Dec 16, 2021
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Dec 16, 2021
The SDK contains logic to configure trimming - we were skipping all of that. We couldn't previously include the SDK because it would reflection-root the entrypoint assembly. No longer the case after dotnet#62890.
MichalStrehovsky
added a commit
that referenced
this pull request
Dec 18, 2021
* Have NativeAOT test execution project include SDK The SDK contains logic to configure trimming - we were skipping all of that. We couldn't previously include the SDK because it would reflection-root the entrypoint assembly. No longer the case after #62890.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<TrimmerRootAssembly Include="myEntrypointAssembly" />won't actually root anything besides the entrypoint with IL Linker. NativeAOT would do what it's instructed to do and root the whole assembly. This is showing up as a difference because the SDK auto-injects this root into all trimmed projects and the resulting apps are not as small as they could be.