Skip to content

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Dec 16, 2021

Fixes #60330

it needs a better forward-sub pass (I am planning to come up with a prototype soon) to properly substitute struct types, currently we might end up with:

               [000021] n----------- arg1         +--*  OBJ       simd12<System.Numerics.Vector3>
               [000020] ------------              |  \--*  ADDR      byref
               [000009] ------------              |     \--*  LCL_VAR

after fsub:

               [000021] n----------- arg1         +--*  OBJ       simd12<System.Numerics.Vector3>
               [000020] ------------              |  \--*  ADDR      byref
               [000009] ------------              |     \--*  HWINTRINSIC simd12 float get_Zero

while expected to be:

               [000009] ------------              +--*  HWINTRINSIC simd12 float get_Zero

cc @kunalspathak

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 16, 2021
@ghost ghost assigned EgorBo Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60330

it needs a better forward-sub pass (I am planning to come up with a prototype soon) to properly substitute struct types, currently we might end up with:

               [000021] n----------- arg1         +--*  OBJ       simd12<System.Numerics.Vector3>
               [000020] ------------              |  \--*  ADDR      byref
               [000009] ------------              |     \--*  HWINTRINSIC simd12 float get_Zero

cc @kunalspathak

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Contributor

So this reverts part of #55875? Curious to see asmdiff (when they are ready)

@kunalspathak
Copy link
Contributor

@dotnet/jit-contrib

@EgorBo
Copy link
Member Author

EgorBo commented Dec 16, 2021

So this reverts part of #

Yes, but I am working on a forward sub for FPTR (function pointers) nodes locally and will handle this case too. For now I just want to unblock the CI. the diff is expected to be very small

@SingleAccretion
Copy link
Contributor

Fixes #62815 too (or was the issue number not quite correct in the PR description)?

@BruceForstall
Copy link
Contributor

@EgorBo EgorBo merged commit 5a5d379 into dotnet:main Dec 17, 2021
@kunalspathak
Copy link
Contributor

@EgorBo - could you confirm that this fixes #62815 as well and if yes, close it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failed 'child->isContained()'

4 participants