Skip to content

[wasm] Fix imports: require, exit, quit #62712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 3 commits into from
Dec 14, 2021
Merged

[wasm] Fix imports: require, exit, quit #62712

pavelsavara merged 3 commits into from
Dec 14, 2021

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 13, 2021 •
edited
Loading

  • simplify exit, exit
  • fix require
  • change default value of disableDotnet6Compatibility based on ES6 or CJS.

@pavelsavara
- fix require
4ee9311 
- simplify exit, quit
@pavelsavara pavelsavara added this to the 7.0.0 milestone Dec 13, 2021
@pavelsavara pavelsavara requested review from kg and maraf December 13, 2021 11:10
@ghost
Copy link

ghost commented Dec 13, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • simplify exit, exit
  • fix require
Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 13, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 13, 2021

Azure Pipelines successfully started running 1 pipeline(s).

kasperk81
kasperk81 reviewed Dec 13, 2021
View reviewed changes
maraf
maraf reviewed Dec 13, 2021
View reviewed changes
@pavelsavara
- whitespace in *.lib.*
f2de752 
- just capture require on top level, replace it later
@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 13, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 13, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara mentioned this pull request Dec 13, 2021
Closed
kg
kg reviewed Dec 13, 2021
View reviewed changes
kg
kg approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenative approval - I don't see anything wrong here but I'm also not sure I understand it

@pavelsavara pavelsavara merged commit a8a10f8 into dotnet:main Dec 14, 2021
@pavelsavara pavelsavara deleted the wasm_fix_require branch January 4, 2022 13:06
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg approved these changes

@maraf maraf maraf approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

+1 more reviewer

@kasperk81 kasperk81 kasperk81 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara @kg @maraf @kasperk81