Fix XXHash for stripe size #61881
Merged
Fix XXHash for stripe size #61881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.IO
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsCloses #61878 Fixes the (multiple of) stripe size case and adds explicit tests for this specific case.
|
filipnavara
approved these changes
Nov 20, 2021
bartonjs
approved these changes
Nov 20, 2021
Contributor
Author
|
The build failure does not appear to be related, an arm debug build was terminated after a timeout. |
adamsitnik
approved these changes
Nov 22, 2021
Member
|
Given the incorrectly generated results and pretty small area of the fix I'd say it's worth porting to release branch (especially a LTS one). |
Contributor
Author
|
I'd recommend backporting too. |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1491225615 |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61878
Fixes the (multiple of) stripe size case and adds explicit tests for this specific case.