Skip to content

[TODO-List-Cleanup] Delete the quirks #61876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echesakov merged 2 commits into from
Dec 16, 2021
Merged

[TODO-List-Cleanup] Delete the quirks #61876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db68a8
Remove the VN quirk
SingleAccretion Nov 20, 2021
15e68d2
Delete the costing quirk
SingleAccretion Nov 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2519,13 +2519,6 @@ unsigned Compiler::gtSetMultiOpOrder(GenTreeMultiOp* multiOp)
bool canSwap = multiOp->IsReverseOp() ? gtCanSwapOrder(multiOp->Op(2), multiOp->Op(1))
: gtCanSwapOrder(multiOp->Op(1), multiOp->Op(2));

// The InitN intrinsic for two operands used to be not reversible, so preserve this.
// TODO-List-Cleanup: delete this only-needed-for-zero-diffs quirk.
if (multiOp->OperIs(GT_SIMD) && (multiOp->AsSIMD()->GetSIMDIntrinsicId() == SIMDIntrinsicInitN))
{
canSwap = false;
}

if (canSwap)
{
if (multiOp->IsReverseOp())
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9464,9 +9464,7 @@ void Compiler::fgValueNumberSimd(GenTreeSIMD* tree)
excSetPair = ValueNumStore::VNPForEmptyExcSet();
normalPair = vnStore->VNPairForFunc(tree->TypeGet(), simdFunc);
}
// TODO-List-Cleanup: the "tree->GetSIMDIntrinsicId() == SIMDIntrinsicInitN" case is a quirk
// to get zero diffs - Vector2(float, float) was imported with lists - remove it.
else if ((tree->GetOperandCount() > 2) || (tree->GetSIMDIntrinsicId() == SIMDIntrinsicInitN))
else if (tree->GetOperandCount() > 2)
{
// We have a SIMD node with 3 or more args. To retain the
// previous behavior, we will generate a unique VN for this case.
Expand Down