[wasm] Rework fetch #61639
[wasm] Rework fetch #61639
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
kg
left a comment
kg
left a comment
There was a problem hiding this comment.
Looks fine assuming nothing breaks
| catch (e) { | ||
| return <Response><any> { | ||
| ok: true, | ||
| ok: false, |
There was a problem hiding this comment.
Maybe store the error as a property so the caller can find out what the error was without an extra throw+catch
| } | ||
| else if (ENVIRONMENT_IS_NODE) { | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const fs = require("fs"); |
There was a problem hiding this comment.
This will do require for each call of the _fetch_asset. I admit the previous implementation had the same issue.
Oddly enough that was entirely accidental, I should be a little more careful about what completions I accept. |
|
it seems there are lint issue |
|
I wonder why only staging pipeline failed, not the |
ghost
locked as resolved and limited conversation to collaborators
3 participants
No description provided.