[wasm][debugger] Tie sdb agent lifetime to the ExecutionContext and simplify the api #61392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue Detailsnull
|
lewing
force-pushed
the
binary-writer
branch
from
1607651 to
dc21e4c
Compare
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
Member
Author
|
@thaystg the smaller version is smaller but... |
lewing
force-pushed
the
binary-writer
branch
4 times, most recently
from
214efa8 to
ca4de82
Compare
lewing
force-pushed
the
binary-writer
branch
from
ca4de82 to
1cb95bf
Compare
lewing
force-pushed
the
binary-writer
branch
from
1cb95bf to
94c6e61
Compare
radical
reviewed
Nov 12, 2021
lewing
force-pushed
the
binary-writer
branch
from
23ae205 to
5a7dcd9
Compare
lewing
changed the title
thaystg
approved these changes
Nov 17, 2021
Member
Author
|
Needs a little more work, the merge was slightly off. Working on it now |
Member
Author
|
should be good now. |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework MonoSdbHelper and tie its lifetime to the ExecutionContext to simplify session handling.