Skip to content

Conversation

@echesakov
Copy link
Contributor

Noticed that the code is dead while working on an issue

@dotnet/jit-contrib PTAL

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 2, 2021
@ghost
Copy link

ghost commented Nov 2, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Noticed that the code is dead while working on an issue

@dotnet/jit-contrib PTAL

Author: echesakovMSFT
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I presume no asmdiffs?

@echesakov
Copy link
Contributor Author

LGTM. I presume no asmdiffs?

I will double check this before merging

@echesakov
Copy link
Contributor Author

Confirmed no diffs with spmi on all four platforms.

@echesakov echesakov merged commit 49807bc into dotnet:main Nov 3, 2021
@echesakov echesakov deleted the Remove-Dead-Code branch November 3, 2021 03:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants