[wasm] simplify startup configuration #61072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
kg
reviewed
Nov 2, 2021
kg
reviewed
Nov 2, 2021
kg
reviewed
Nov 2, 2021
kg
approved these changes
Nov 2, 2021
Member
|
@steveisok we need a way to test changes like this in pr without directly fiddling with the yml. I think we should probably turn back on the interpreter lane until we have a way to trigger this cc @marek-safar |
Member
|
I don't have a problem if you want to enable the interp lane until there's an option to manually trigger everything. Remove runtime/eng/pipelines/runtime.yml Line 296 in ec12194 |
* added Module.onConfigLoaded callback * added Module.onDotNetReady replacing MonoConfig.loaded_cb * removed loaded_cb, assembly_list, runtime_assets, runtime_asset_sources from MonoConfig * simplified all sample and test projects * renamed no_global_exports to disableDotNet6Compatibility * implement default Module.preInit and Module.onRuntimeInitialized which could be overriden by user code (like Blazor)
pavelsavara
force-pushed
the
wasm_load_config
branch
from
78c1c10 to
5e4d4e8
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module.configSrc- to configure path toMonoConfigjson fileModule.onConfigLoadedcallbackModule.onDotNetReadyreplacingMonoConfig.loaded_cbloaded_cb,assembly_list,runtime_assets,runtime_asset_sourcesfromMonoConfigModule.no_global_exportstoModule.disableDotNet6CompatibilityModule.preInitandModule.onRuntimeInitializedwhich could be overridden by user code (like Blazor)