Skip to content

Conversation

@lambdageek
Copy link
Member

@lambdageek lambdageek commented Oct 13, 2021

Fix -Wunused-but-set-variable and -Wcast-function-type warnings

Contributes to #60326

`cast from 'void (*)(int, siginfo_t *, void *)' to 'void (*)(int)' converts to incompatible function type`

But going through an intermediate `void (*) (void)` function type is allowed.
It warns, among others, about ICU headers
@ghost
Copy link

ghost commented Oct 13, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix -Wunused-but-set-variable and -Wcast-function-type warnings

Author: lambdageek
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@lambdageek
Copy link
Member Author

@am11 feel free to cherrypick to your PR #60328

@am11
Copy link
Member

am11 commented Oct 13, 2021

#60328 fixes it for clr+libs.native+host.native. We already suppressed Wunused-but-set-variable in gcc which is exercised in the CI, I have set it unconditionally.

@am11 am11 mentioned this pull request Oct 13, 2021
@am11
Copy link
Member

am11 commented Oct 13, 2021

Cherry-picked 2ae38d2.

@lambdageek
Copy link
Member Author

Closing. All the good bits are in #60328

@lambdageek lambdageek closed this Oct 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants