Skip to content

Obsolete thumbtacked AssemblyName properties #59522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 16, 2021
Merged

Obsolete thumbtacked AssemblyName properties #59522

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52cf265
Obsolete thumbtacked AssemblyName properties
i3arnon Sep 23, 2021
ec9f7ae
Ignore obsoletion
i3arnon Sep 23, 2021
486b875
Fix pragma
i3arnon Sep 23, 2021
9f05e44
Merge the AssemblyName member obsoletions into a single diagnostic id
jeffhandley Nov 15, 2021
ff6d7bc
Merge branch 'main' into assembley-name. Update to SYSLIB0037 to addr…
jeffhandley Nov 15, 2021
8455593
Fix pragma to use updated diagnostic id
jeffhandley Nov 15, 2021
b0ee59a
Suppress SYSLIB0037 in reflection tests
jeffhandley Nov 15, 2021
8d62a80
Suppress SYSLIB0037 warnings
jeffhandley Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/project/list-of-diagnostics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ The PR that reveals the implementation of the `<IncludeInternalObsoleteAttribute
| __`SYSLIB0033`__ | Rfc2898DeriveBytes.CryptDeriveKey is obsolete and is not supported. Use PasswordDeriveBytes.CryptDeriveKey instead. |
| __`SYSLIB0034`__ | CmsSigner(CspParameters) is obsolete and is not supported. Use an alternative constructor instead. |
| __`SYSLIB0035`__ | ComputeCounterSignature without specifying a CmsSigner is obsolete and is not supported. Use the overload that accepts a CmsSigner. |
| __`SYSLIB0036`__ | AssemblyName.HashAlgorithm has been deprecated and is not supported. |
| __`SYSLIB0037`__ | AssemblyName.ProcessorArchitecture has been deprecated and is not supported. |
| __`SYSLIB0038`__ | AssemblyName.VersionCompatibility has been deprecated and is not supported. |

## Analyzer Warnings

Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/System.Private.CoreLib/src/System/Reflection/AssemblyName.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ internal static AssemblyName GetFileInformationCore(string assemblyFile)

internal void SetProcArchIndex(PortableExecutableKinds pek, ImageFileMachine ifm)
{
#pragma warning disable SYSLIB0037
ProcessorArchitecture = CalculateProcArchIndex(pek, ifm, _flags);
#pragma warning restore SYSLIB0037
}

internal static ProcessorArchitecture CalculateProcArchIndex(PortableExecutableKinds pek, ImageFileMachine ifm, AssemblyNameFlags flags)
Expand Down
9 changes: 9 additions & 0 deletions src/libraries/Common/src/System/Obsoletions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,14 @@ internal static class Obsoletions

internal const string SignerInfoCounterSigMessage = "ComputeCounterSignature without specifying a CmsSigner is obsolete and is not supported. Use the overload that accepts a CmsSigner.";
internal const string SignerInfoCounterSigDiagId = "SYSLIB0035";

internal const string AssemblyHashAlgorithmMessage = "AssemblyName.HashAlgorithm has been deprecated and is not supported.";
internal const string AssemblyHashAlgorithmDiagId = "SYSLIB0036";

internal const string ProcessorArchitectureMessage = "AssemblyName.ProcessorArchitecture has been deprecated and is not supported.";
internal const string ProcessorArchitectureDiagId = "SYSLIB0037";

internal const string AssemblyVersionCompatibilityMessage = "AssemblyName.VersionCompatibility has been deprecated and is not supported.";
internal const string AssemblyVersionCompatibilityDiagId = "SYSLIB0038";
}
}
3 changes: 3 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyName.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public string? EscapedCodeBase
}
}

[Obsolete(Obsoletions.ProcessorArchitectureMessage, DiagnosticId = Obsoletions.ProcessorArchitectureDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
public ProcessorArchitecture ProcessorArchitecture
{
get
Expand Down Expand Up @@ -189,12 +190,14 @@ public AssemblyNameFlags Flags
}
}

[Obsolete(Obsoletions.AssemblyHashAlgorithmMessage, DiagnosticId = Obsoletions.AssemblyHashAlgorithmDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
public AssemblyHashAlgorithm HashAlgorithm
{
get => _hashAlgorithm;
set => _hashAlgorithm = value;
}

[Obsolete(Obsoletions.AssemblyVersionCompatibilityMessage, DiagnosticId = Obsoletions.AssemblyVersionCompatibilityDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
public AssemblyVersionCompatibility VersionCompatibility
{
get => _versionCompatibility;
Expand Down