Skip to content

Fix gtCloneExpr when cloning during R2R compilation a GT_ALLOCOBJ node #59395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidwrighton merged 2 commits into from
Sep 21, 2021
Merged

Fix gtCloneExpr when cloning during R2R compilation a GT_ALLOCOBJ node #59395

davidwrighton merged 2 commits into from
Sep 21, 2021

Conversation

@davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Sep 21, 2021

  • Without this fix cloned expressions with allocations will fail
  • This is most common in profile guided code around devirtualization, but I believe it can occur in other where gtCloneExpr is used
  • Symptom of the failure is a compilation failure during crossgen2

@davidwrighton
Fix gtCloneExpr when cloning during R2R compilation a GT_ALLOCOBJ node
a2ff685 
- Without this fix cloned expressions with allocations will fail
- This is most common in profile guided code around devirtualization, but I believe it can occur in other where gtCloneExpr is used
- Symptom of the failure is a compilation failure during crossgen2
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 21, 2021
@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Without this fix cloned expressions with allocations will fail
  • This is most common in profile guided code around devirtualization, but I believe it can occur in other where gtCloneExpr is used
  • Symptom of the failure is a compilation failure during crossgen2
Author: davidwrighton
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@davidwrighton
Copy link
Member Author

davidwrighton commented Sep 21, 2021

@JulieLeeMSFT @AndyAyersMS I'd like to see us get this fix into the 6.0 release branch. Its blocking some PGO scenarios in high value customer code.

AndyAyersMS
AndyAyersMS approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AndyAyersMS
Copy link
Member

AndyAyersMS commented Sep 21, 2021

I'd like to see us get this fix into the 6.0 release branch

Seems like this should qualify, yes.

@davidwrighton davidwrighton merged commit 03bc2c2 into dotnet:main Sep 21, 2021
@davidwrighton
Copy link
Member Author

davidwrighton commented Sep 21, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1258731132

@github-actions github-actions bot mentioned this pull request Sep 21, 2021
Closed
@davidwrighton davidwrighton mentioned this pull request Sep 21, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@davidwrighton davidwrighton deleted the fix_clone_expr_readytorun branch April 13, 2023 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidwrighton @AndyAyersMS