Add explicit APIs to Double/Single/Half/TimeOnly #58774
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
pgovind
changed the title
pgovind
changed the title
| => Math.Truncate(x); | ||
|
|
||
| [RequiresPreviewFeatures] | ||
| static bool IFloatingPoint<double>.IsFinite(double d) => IsFinite(d); |
There was a problem hiding this comment.
I didn't add tests for the new APIs since I didn't find tests for the other generic math APIs in Double/Single/Half. I assumed we'll add them as part of adding other unit tests here.
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks for handling this, @pgovind. Once we get this merged into main, we'll want to backport this into release/6.0 and submit it for RC2 approval.
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsAs part of running CA2252 locally to test the dotnet/runtime build, the CA2252 analyzer tagged these APIs as being implicit implementations that didn't have the cc @jeffhandley
|
|
The failing check is from System.Net.Http.WinHttpHandler.Functional.Tests and it was an unrelated networking issue. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@danmoseley I'm not sure how to resolve or work around the license/cla check failing to finish. Aside from that this is ready to merge. Do you know how to get past that? |
|
@Anipik, @ViktorHofer, @safern : Any idea how to get past the license/cla check? I don't see a re-run option for that leg. |
|
@dotnet/dnceng any idea why license/cla got jammed? Its not this PR that did it. @pgovind there is always the close/reopen option .. |
This has happened occasionally (I found this issue a while ago cla-assistant/cla-assistant#528). Closing and reopening the PR is probably the best way to mitigate this issue. |
|
@missymessa thanks ... is it worth you opening a new issue there? |
|
It appears there is another open issue where lots of folks are reporting seeing the issue: cla-assistant/cla-assistant#520 |
Yea, I considered that, but decided that one of the infra folks using their special powers to merge the PR would be better :) I see you closed and re-opened the PR, so never mind! |
|
The CI checks had previously finished, so I'm going to go ahead and merge. |
I too have such special powers BTW. But for something like "licensing/CLA" it is probably good to make certain it runs. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1215421182 |
|
FYI: since opening and reopening triggers all other legs, the best way to trigger the CLA run when it doesn't run is using the following address: https://cla.dotnetfoundation.org/check/%org%/%repo%?pullRequest=%pr% |
ghost
locked as resolved and limited conversation to collaborators
5 participants
As part of running CA2252 locally to test the dotnet/runtime build, the CA2252 analyzer tagged these APIs as being implicit implementations that didn't have the
[RequiresPreviewFeatures]attribute. This PR fixes that.cc @jeffhandley