Skip to content

[debugger] Avoid calling debugger_agent_single_step_from_context when thread is not attached yet #58467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 2 commits into from
Sep 1, 2021
Merged

[debugger] Avoid calling debugger_agent_single_step_from_context when thread is not attached yet #58467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49c05f0
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1383962
thaystg Aug 31, 2021
0606dbb
Fix {
thaystg Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/mono/mono/mini/method-to-ir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6078,6 +6078,14 @@ mono_method_to_ir (MonoCompile *cfg, MonoMethod *method, MonoBasicBlock *start_b
seq_points = FALSE;
}

if (method->wrapper_type == MONO_WRAPPER_OTHER) {
WrapperInfo *info = mono_marshal_get_wrapper_info (method);
if (info->subtype == WRAPPER_SUBTYPE_INTERP_IN) {
/* We could hit a seq point before attaching to the JIT (#8338) */
seq_points = FALSE;
Copy link
Member

@lambdageek lambdageek Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrzVlad Are there other wrappers that might be used to go from native embedder code to the interp?

@vargaz Do we need sequence points in any wrappers? How risky would it be to just disable them for all wrapper methods? Are they used for stopping on a call to a pinvoke or something like that?

Copy link
Member

@BrzVlad BrzVlad Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the only one

}
}

if (cfg->prof_coverage) {
if (cfg->compile_aot)
g_error ("Coverage profiling is not supported with AOT.");
Expand Down