Nullable improvement for Microsoft.Extensions.Primitives.StringSegment
#58264
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Detailsnull
|
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this up!
| public StringSegment(string buffer, int offset, int length) { throw null; } | ||
| public string? Buffer { get { throw null; } } | ||
| [System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, nameof(Buffer))] | ||
| [System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, nameof(Value))] |
There was a problem hiding this comment.
FYI - @stephentoub. Now there are 2 public usages of this attribute 😄.
|
This is approved and it would be great to have a build including this for dotnet/aspnetcore#35547 without pulling in lots of other nullability changes.
|
Thanks❕ I'll watch the next dotnet-runtime-official build.
Yup. I'm working on my reaction to those additional changes in dotnet/aspnetcore#35547. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
No description provided.