Skip to content

[HTTP/3] Reenabled ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream #58041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManickaP merged 1 commit into from
Aug 30, 2021
Merged

[HTTP/3] Reenabled ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream #58041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ await LoopbackServer.CreateClientAndServerAsync(async proxyUri =>

public static IEnumerable<object[]> SecureAndNonSecure_IPBasedUri_MemberData() =>
from address in new[] { IPAddress.Loopback, IPAddress.IPv6Loopback }
from useSsl in BoolValues
from useSsl in BoolValues
// we could not create SslStream in browser, [ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
where PlatformDetection.IsNotBrowser || !useSsl
where PlatformDetection.IsNotBrowser || !useSsl
select new object[] { address, useSsl };

[Theory]
Expand Down Expand Up @@ -951,12 +951,6 @@ public async Task ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream(boo
return;
}

if (UseVersion == HttpVersion30 && (chunked is null || chunked is false))
{
// [ActiveIssue("https://github.com/dotnet/runtime/issues/53087")]
return;
}

await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
var request = new HttpRequestMessage(HttpMethod.Get, uri) { Version = UseVersion };
Expand Down