Skip to content

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Aug 9, 2021

This should give us a test failure like the following:

    Assert.Contains() Failure
Not found: Pipe.GetFlushResult2
In value:     at System.IO.Pipelines.Tests.FlushAsyncTests.<FlushAsync_ThrowsIfWriterReaderWithException>g__ThrowTestException|1_0() in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\tests\FlushAsyncTests.cs:line 32
--- End of stack trace from previous location ---
   at System.IO.Pipelines.Pipe.GetFlushResult(FlushResult& result) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.cs:line 1021
   at System.IO.Pipelines.Pipe.PrepareFlush(CompletionData& completionData, ValueTask`1& result, CancellationToken cancellationToken) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.cs:line 369
   at System.IO.Pipelines.Pipe.FlushAsync(CancellationToken cancellationToken) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.cs:line 350
   at System.IO.Pipelines.Pipe.DefaultPipeWriter.FlushAsync(CancellationToken cancellationToken) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.DefaultPipeWriter.cs:line 32
   at System.IO.Pipelines.Tests.FlushAsyncTests.<FlushAsync_ThrowsIfWriterReaderWithException>b__1_2() in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\tests\FlushAsyncTests.cs:line 48
   at Xunit.Assert.RecordExceptionAsync(Func`1 testCode) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\Record.cs:line 81

Instead of

     System.IO.Pipelines.Tests.FlushAsyncTests.FlushAsync_ThrowsIfWriterReaderWithException [FAIL]
       The collection was expected to contain a single element, but it was empty.
       Stack Trace:
         C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\tests\FlushAsyncTests.cs(52,0): at System.IO.Pipelines.Tests.FlushAsyncTests.FlushAsync_ThrowsIfWriterReaderWithException()
         --- End of stack trace from previous location ---

I'm hoping this helps with debugging.

This is to help investigate #55435

@ghost ghost added the area-System.IO label Aug 9, 2021
@ghost
Copy link

ghost commented Aug 9, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

This should give us a test failure like the following:

    Assert.Contains() Failure
Not found: Pipe.GetFlushResult2
In value:     at System.IO.Pipelines.Tests.FlushAsyncTests.<FlushAsync_ThrowsIfWriterReaderWithException>g__ThrowTestException|1_0() in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\tests\FlushAsyncTests.cs:line 32
--- End of stack trace from previous location ---
   at System.IO.Pipelines.Pipe.GetFlushResult(FlushResult& result) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.cs:line 1021
   at System.IO.Pipelines.Pipe.PrepareFlush(CompletionData& completionData, ValueTask`1& result, CancellationToken cancellationToken) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.cs:line 369
   at System.IO.Pipelines.Pipe.FlushAsync(CancellationToken cancellationToken) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.cs:line 350
   at System.IO.Pipelines.Pipe.DefaultPipeWriter.FlushAsync(CancellationToken cancellationToken) in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\src\System\IO\Pipelines\Pipe.DefaultPipeWriter.cs:line 32
   at System.IO.Pipelines.Tests.FlushAsyncTests.<FlushAsync_ThrowsIfWriterReaderWithException>b__1_2() in C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\tests\FlushAsyncTests.cs:line 48
   at Xunit.Assert.RecordExceptionAsync(Func`1 testCode) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\Record.cs:line 81

Instead of

     System.IO.Pipelines.Tests.FlushAsyncTests.FlushAsync_ThrowsIfWriterReaderWithException [FAIL]
       The collection was expected to contain a single element, but it was empty.
       Stack Trace:
         C:\dev\dotnet\runtime\src\libraries\System.IO.Pipelines\tests\FlushAsyncTests.cs(52,0): at System.IO.Pipelines.Tests.FlushAsyncTests.FlushAsync_ThrowsIfWriterReaderWithException()
         --- End of stack trace from previous location ---

I'm hoping this helps with debugging.

Author: halter73
Assignees: -
Labels:

area-System.IO

Milestone: -

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halter73
Copy link
Member Author

halter73 commented Aug 9, 2021

Given that #55446 has been merged, will I see any new failures? I don't see failures since 7/10, but I'm struggling to adjust the date range the Azure Pipelines test history UI, so I could be missing something.

@halter73 halter73 merged commit c6cad84 into main Aug 10, 2021
@halter73 halter73 deleted the halter73/55435 branch August 10, 2021 21:03
@adamsitnik adamsitnik added this to the 6.0.0 milestone Aug 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants