Make LambdaCompiler prefer interpretation to compilation on iOS #54970

MaximLipnin · 2021-06-30T16:53:35Z

This is an attempt to address #47112 based on Egor's suggestion.
The changes:

set IsInterpreting MSBuild property to 'true' in case of iOS;
made System.Linq.Expressions.ExpressionCreator class internal static in order not to introduce new public type; otherwise it throws Type 'System.Linq.Expressions.ExpressionCreator<TDelegate>' does not exist in the reference but it does exist in the implementation.
updated the iOS simulator functional test for AOT to verify the fix
added PlatformDetection.IsLinqExpressionsBuiltWithIsInterpretingOnly which checks whether the System.Linq.Expressions is built with IsInterpreting property set to true. To do so, it uses reflection to verify the Expression.Accept method doesn't exist.
disabled some failing library tests using ActiveIssue + PlatformDetection.
updated the invariant functional test for the iOS simulator (b/c of Allow restricting cultures creation with any arbitrary names in Globalization Invariant Mode #54247)

ghost · 2021-06-30T16:53:42Z

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

This is an attempt to address #47112 based on Egor's suggestion.
The changes:

set IsInterpreting MSBuild property to 'true' in case of iOS;
made System.Linq.Expressions.ExpressionCreator class internal static in order not to introduce new public type; otherwise it throws Type 'System.Linq.Expressions.ExpressionCreator<TDelegate>' does not exist in the reference but it does exist in the implementation.
updated the iOS simulator functional test for AOT to verify the fix.

Author:	MaximLipnin
Assignees:	-
Labels:	`area-System.Linq.Expressions`
Milestone:	-

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj

Co-authored-by: Stephen Toub <[email protected]>

src/tests/FunctionalTests/iOS/Simulator/AOT/Program.cs

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj

MaximLipnin · 2021-07-01T15:20:27Z

Actually, System.Linq.Expressions.Tests failed on the iOS simulator with the following errors:

1. System.Linq.Expressions.Tests.CompilerTests test suite
System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

2. System.Linq.Expressions.Tests.ExceptionHandlingExpressions.TryFinallyWithinFilterCompiledProhibited
Assert.Throws() Failure\nExpected: typeof(System.InvalidOperationException)\nActual:   (No exception was thrown)

3. 
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Block_Closure(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Lambda_Closure2(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Lambda_Closure1(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_Variable_Closure1(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_NoVariable_Closure2(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_Variable_Closure2(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_CatchBlock_NoVariable_Closure1(useInterpreter: False)
System.Linq.Expressions.Tests.UnaryQuoteTests.Quote_Block_LocalAndClosure(useInterpreter: False)

Xunit.Sdk.EqualException: Assert.Equal() Failure\nExpected: MemberAccess\nActual:   Convert 

4. 
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeFunc(typeArgs: [typeof(string), typeof(System.Double*), typeof(int)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.Int32*)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(int), typeof(System.String*), typeof(double)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(int), typeof(System.Int32&amp;), typeof(string)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(string), typeof(System.Double*), typeof(int)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.String*)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.Collections.Generic.List&lt;int&gt;), typeof(System.Collections.Generic.List&lt;int&gt;), typeof(System.Collections.Generic.List&lt;int&gt;), typeof(System.Collections.Generic.List&lt;int&gt;), typeof(System.Collections.Generic.List&lt;int&gt;), ...])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.String*), typeof(System.String*), typeof(System.String*), typeof(System.String*), typeof(System.String*), ...])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.Span&lt;char&gt;)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(int), typeof(int), typeof(int), typeof(int), typeof(int), ...])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.Int32&amp;)])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.Int32*), typeof(System.Int32*), typeof(System.Int32*), typeof(System.Int32*), typeof(System.Int32*), ...])
System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeAction(typeArgs: [typeof(System.Double&amp;), typeof(System.Double&amp;), typeof(System.Double&amp;), typeof(System.Double&amp;), typeof(System.Double&amp;), ...])

System.PlatformNotSupportedException : Operation is not supported on this platform.
   at System.Linq.Expressions.Compiler.DelegateHelpers.MakeNewCustomDelegate(Type[] types)
   at System.Linq.Expressions.Compiler.DelegateHelpers.MakeNewDelegate(Type[] types)
   at System.Linq.Expressions.Compiler.DelegateHelpers.MakeDelegateType(Type[] types)
   at System.Linq.Expressions.Expression.GetDelegateType(Type[] typeArgs)
   at System.Linq.Expressions.Tests.GetDelegateTypeTests.CantBeFunc(Type[] typeArgs)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

5. System.Linq.Expressions.Tests.NewWithByRefParameterTests.CreateByRefAliasingCompiled
Assert.Equal() Failure\nExpected: 16\nActual:   12

6. System.Dynamic.Tests.InvokeMemberBindingTests.InvokeVirtualMethod(value: 0)
Assert.Equal() Failure\n          ↓ (pos 0)\nExpected: 0\nActual:   -1307871456\n          ↑ (pos 0)
at System.Linq.Expressions.Interpreter.ActionCallInstruction`2[[System.String, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.LightLambda.RunVoid(Object[] arguments)
   at System.Linq.Expressions.Interpreter.CallInstruction.InterpretLambdaInvoke(LightLambda targetLambda, Object[] args)
   at System.Linq.Expressions.Interpreter.MethodInfoCallInstruction.Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.LightLambda.RunVoid(Object[] arguments)
   at System.Dynamic.Tests.InvokeMemberBindingTests.InvokeVirtualMethod(Object value)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

7. System.Dynamic.Tests.InvokeMemberBindingTests.InvokeFuncMember
System.ArgumentException : Expression of type 'System.Int32' cannot be used for parameter of type 'System.Object' (Parameter 'arg2')

    at System.Dynamic.Utils.ExpressionUtils.ValidateOneArgument(MethodBase method, ExpressionType nodeKind, Expression arguments, ParameterInfo pi, String methodParamName, String argumentParamName, Int32 index)
   at System.Linq.Expressions.Expression.ValidateOneArgument(MethodBase method, ExpressionType nodeKind, Expression arg, ParameterInfo pi, String methodParamName, String argumentParamName)
   at System.Linq.Expressions.Expression.Invoke(Expression expression, Expression arg0, Expression arg1, Expression arg2)
   at System.Linq.Expressions.Expression.Invoke(Expression expression, IEnumerable`1 arguments)
   at System.Linq.Expressions.DynamicExpression.Reduce()
   at System.Linq.Expressions.Expression.ReduceAndCheck()
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileNoLabelPush(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.Compile(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileGotoExpression(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileNoLabelPush(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileAsVoid(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.Compile(Expression expr, Boolean asVoid)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileConditionalExpression(Expression expr, Boolean asVoid)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileNoLabelPush(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileAsVoid(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileBlockStart(BlockExpression node)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileBlockExpression(Expression expr, Boolean asVoid)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileNoLabelPush(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.Compile(Expression expr)
   at System.Linq.Expressions.Interpreter.LightCompiler.CompileTop(LambdaExpression node)
   at System.Linq.Expressions.Expression`1[[<>A{00000004}`3[[System.Runtime.CompilerServices.CallSite, System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Linq.Expressions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].Compile()
   at System.Runtime.CompilerServices.CallSiteBinder.BindCore[<>A{00000004}`3](CallSite`1 site, Object[] args)
   at System.Runtime.CompilerServices.CallSiteOps.Bind[<>A{00000004}`3](CallSiteBinder binder, CallSite`1 site, Object[] args)
   at System.Linq.Expressions.Interpreter.FuncCallInstruction`4[[System.Runtime.CompilerServices.CallSiteBinder, System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a],[System.Runtime.CompilerServices.CallSite`1[[<>A{00000004}`3[[System.Runtime.CompilerServices.CallSite, System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Linq.Expressions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]], System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a],[System.Object[], System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[<>A{00000004}`3[[System.Runtime.CompilerServices.CallSite, System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a],[System.Object, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Linq.Expressions.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.Interpreter.Run(InterpretedFrame frame)
   at System.Linq.Expressions.Interpreter.LightLambda.RunVoid(Object[] arguments)
   at System.Dynamic.Tests.InvokeMemberBindingTests.InvokeFuncMember()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture

steveisok · 2021-07-01T15:45:05Z

Actually, System.Linq.Expressions.Tests failed on the iOS simulator with the following errors:

Can you file separate issues for each and tag them with ActiveIssue so that they are skipped? We may need someone from the libraries team to help us sort things out.

…j file

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj

src/libraries/System.Linq.Expressions/tests/Dynamic/InvokeMemberBindingTests.cs

…led as IsInterpreting only

steveisok

LGTM - I think it makes sense to follow up w/ wasm changes.

Make LambdaCompiler prefer interpretation to compilation on iOS

f4d448c

MaximLipnin requested review from akoeplinger, directhex, marek-safar, mdh1418 and steveisok June 30, 2021 16:53

ghost added the area-System.Linq.Expressions label Jun 30, 2021

stephentoub reviewed Jun 30, 2021

View reviewed changes

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj Outdated Show resolved Hide resolved

Simplify the condition

c05dfd5

Co-authored-by: Stephen Toub <[email protected]>

marek-safar reviewed Jun 30, 2021

View reviewed changes

src/tests/FunctionalTests/iOS/Simulator/AOT/Program.cs Outdated Show resolved Hide resolved

marek-safar reviewed Jun 30, 2021

View reviewed changes

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj Outdated Show resolved Hide resolved

steveisok reviewed Jun 30, 2021

View reviewed changes

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj Outdated Show resolved Hide resolved

MaximLipnin added 3 commits July 1, 2021 10:34

Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios

bdac243

Extend the IsInterpreting condition to the other apple mobile platforms

c6ebcfd

Extract a separate functional test

dac905e

MaximLipnin added 3 commits July 2, 2021 10:35

Set the right condition for IsInterpreting property in the test cspro…

0987d1f

…j file

Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios

ae5d13d

Disable a couple of tests

79e2afd

marek-safar reviewed Jul 2, 2021

View reviewed changes

src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj Show resolved Hide resolved

marek-safar reviewed Jul 2, 2021

View reviewed changes

src/libraries/System.Linq.Expressions/tests/Dynamic/InvokeMemberBindingTests.cs Outdated Show resolved Hide resolved

Use PlatformDetection to check that System.Linq.Expressions was compi…

4f94240

…led as IsInterpreting only

MaximLipnin added 9 commits July 3, 2021 09:34

Disable failing System.Dynamic.Runtime library tests

01068dd

Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios

21e7084

Address issue with Microsoft.VisualBasic.CompilerServices.Tests

2520971

Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios

bb5abac

Fix build issue

9fa02a6

Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios

940a10d

Revert the test

a4813f9

Update the invariant functional test for ios simulator

c3a3530

Re-enable some SLE tests on tvOS

ab03032

MaximLipnin mentioned this pull request Jul 6, 2021

[tvOS] System.Linq.Expression.Tests Hang on tvOS #51952

Closed

MaximLipnin added 2 commits July 6, 2021 12:47

Merge branch 'main' into prefer_interp_for_lambda_compiler_on_ios

7c6ee4f

Disable Microsoft.CSharp library test suite due to app crash in CI

038b4d5

MaximLipnin marked this pull request as ready for review July 6, 2021 19:48

steveisok approved these changes Jul 9, 2021

View reviewed changes

akoeplinger approved these changes Jul 9, 2021

View reviewed changes

steveisok merged commit 3319fa8 into dotnet:main Jul 9, 2021

MaximLipnin deleted the prefer_interp_for_lambda_compiler_on_ios branch July 9, 2021 13:01

MaximLipnin mentioned this pull request Jul 9, 2021

Using the Mono interpreter with FEATURE_COMPILE #55396

Open

ManickaP mentioned this pull request Jul 20, 2021

[QUIC] Remove AppContext switch from S.N.Quic #56027

Merged

karelz mentioned this pull request Jul 28, 2021

[WinHttpHandler] Long running test: ResponseHeadersRead_SynchronizationContextNotUsedByHandler on Win7/Win8 #54034

Closed

ghost locked as resolved and limited conversation to collaborators Aug 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make LambdaCompiler prefer interpretation to compilation on iOS #54970

Make LambdaCompiler prefer interpretation to compilation on iOS #54970

Uh oh!

MaximLipnin commented Jun 30, 2021 •

edited

Loading

Uh oh!

ghost commented Jun 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaximLipnin commented Jul 1, 2021

Uh oh!

steveisok commented Jul 1, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

steveisok left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Make LambdaCompiler prefer interpretation to compilation on iOS #54970

Make LambdaCompiler prefer interpretation to compilation on iOS #54970

Uh oh!

Conversation

MaximLipnin commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaximLipnin commented Jul 1, 2021

Uh oh!

steveisok commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveisok left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MaximLipnin commented Jun 30, 2021 •

edited

Loading

steveisok commented Jul 1, 2021 •

edited

Loading

steveisok left a comment •

edited

Loading