[Mono] Change output dir for runtime tests running on Android #53384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
akoeplinger,
greenEkatherine,
imhameed and
premun
|
Tagging subscribers to this area: @directhex Issue DetailsFixes #53381
|
imhameed
approved these changes
May 28, 2021
Member
Author
premun
reviewed
May 28, 2021
| fi | ||
| $__Command $HARNESS_RUNNER android test --instrumentation="net.dot.MonoRunner" --package-name="net.dot.$__Category" --app="$__TestBinaryBase/$__Category.apk" --output-directory=`pwd` --arg=entrypoint:libname=$(MsBuildProjectName).dll --expected-exit-code=100 -v | ||
| $__Command $HARNESS_RUNNER android test --instrumentation="net.dot.MonoRunner" --package-name="net.dot.$__Category" --app="$__TestBinaryBase/$__Category.apk" --output-directory=`$HELIX_WORKITEM_UPLOAD_ROOT` --arg=entrypoint:libname=$(MsBuildProjectName).dll --expected-exit-code=100 -v |
Member
There was a problem hiding this comment.
@fanyang-mono I guess you want rather "?
--output-directory=`$HELIX_WORKITEM_UPLOAD_ROOT`
--output-directory="$HELIX_WORKITEM_UPLOAD_ROOT"
Not a big deal and can be fixed in the future but I guess we don't need to invoke a subshell for that
Member
Author
There was a problem hiding this comment.
Good catch! Will incorporate the the fix for future PR.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53381