Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations to netcoreapp3.1 #53358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
added
area-Infrastructure-libraries
breaking-change
ViktorHofer
requested review from
eiriktsarpalis,
jozkee,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Detailsprojects to netcoreapp3.1 and cleaning up conditions so that future Adding NETStandardError markers to prevent available netstandard2.0 For more details please see the reasoning in the linked issue. Contributes to #53282
|
ghost
added
the
needs-breaking-change-doc-created
Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations in projects to netcoreapp3.1 and cleaning up conditions so that future tfm upgrades require less project file changes. Adding NETStandardError markers to prevent available netstandard2.0 assets being picked instead, same as already done for System.Speech and others. For more details please see the reasoning in the linked issue. Contributes to dotnet#53282
ViktorHofer
force-pushed
the
UpgradeToNetCoreApp31
branch
from
9687281 to
fa10975
Compare
Anipik
reviewed
May 27, 2021
Anipik
reviewed
May 27, 2021
Anipik
approved these changes
May 27, 2021
Contributor
Anipik
left a comment
Anipik
left a comment
There was a problem hiding this comment.
couple of comments, other than that looks good
This was referenced May 28, 2021
ghost
locked as resolved and limited conversation to collaborators
ViktorHofer
removed
the
needs-breaking-change-doc-created
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations to netcoreapp3.1
and cleaning up conditions so that future tfm upgrades require less project file changes.
Adding NETStandardError markers to prevent available netstandard2.0 assets being picked
instead, same as already done for System.Speech and others.
For more details please see the reasoning in the linked issue.
Contributes to #53282