Skip to content

Put failing WebSockets tests under ActiveIssue for Android #52647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 1 commit into from
May 12, 2021
Merged

Put failing WebSockets tests under ActiveIssue for Android #52647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ public async Task LargeMessageSplitInMultipleFrames(int windowBits)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52645", TestPlatforms.Android)]
public async Task WebSocketWithoutDeflateShouldThrowOnCompressedMessage()
{
WebSocketTestStream stream = new();
Expand All @@ -363,6 +364,7 @@ public async Task WebSocketWithoutDeflateShouldThrowOnCompressedMessage()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52645", TestPlatforms.Android)]
public async Task ReceiveUncompressedMessageWhenCompressionEnabled()
{
// We should be able to handle the situation where even if we have
Expand All @@ -378,7 +380,7 @@ public async Task ReceiveUncompressedMessageWhenCompressionEnabled()
DangerousDeflateOptions = new WebSocketDeflateOptions()
});

// Server sends uncompressed
// Server sends uncompressed
await SendTextAsync("Hello", server);

// Although client has deflate options, it should still be able
Expand All @@ -399,6 +401,7 @@ public async Task ReceiveUncompressedMessageWhenCompressionEnabled()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52645", TestPlatforms.Android)]
public async Task ReceiveInvalidCompressedData()
{
WebSocketTestStream stream = new();
Expand Down