Fix for failing WebSocket deflate test on ARM #52052
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
|
FYI: CI failures are ongoing infra issue. I will rerun checks after it's fixed |
src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs
Outdated
Show resolved
Hide resolved
|
I don't think this should say "Fixes #52031" because we need that issue to remain open to fix the product bug, presumably |
|
Let's close this until we know the naswer. |
|
As per investigation in #52031 (comment) the fix is working. |
… performance of test on ARM.
zlatanov
force-pushed
the
websockets-test-fix
branch
from
45b7656 to
1e10516
Compare
|
The failing test for websockets indicate that embedded resources haven't been loaded on Android. Is this considered bug somewhere, or if it's common enough, we can remove the message check, and only assert the exception type? |
|
As I understand, we can ignore that for now. Android test failures are treated as a separate effort. In fact, Android tests are part of separate |
|
@steveisok for the Android issue as I've seen it also. |
|
I would prefer the failing tests for Android have an ActiveIssue attribute associated to them for now. |
|
Timings from CI for 15 bits: |
As per #52052 (comment), putting the failing tests under ActiveIssue. Tracking issue: #52645
ghost
locked as resolved and limited conversation to collaborators
5 participants
Fixes #52031