[release/5.0] backport card mark stealing fix to 5.0 #51718
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsPort #51104 to Release/5.0 when we have an object that straddles the 2mb boundary for card mark stealing, we could get into a very specific situation where we process the same card twice right after the 2mb boundary and mistakenly erase it. we fix this by avoid processing the same card twice. #51104 has the detailed description of how this can happen. Customer Impactthis causes an AV because GC would reclaim objects it shouldn't Testingtested locally and the customer who hit this has already tested a private 5.0 build and verified it fixed their problem. Regressionno. this existed when we checked in the card mark stealing work in 5.0 (which means this only exists in 5.0).
|
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Once you get a CR, I can take it for consideration in 5.0.x.
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
5 participants
Port #51104 to Release/5.0
when we have an object that straddles the 2mb boundary for card mark stealing, we could get into a very specific situation where we process the same card twice right after the 2mb boundary and mistakenly erase it. we fix this by avoid processing the same card twice. #51104 has the detailed description of how this can happen.
Customer Impact
this causes an AV because GC would reclaim objects it shouldn't
Testing
tested locally and the customer who hit this has already tested a private 5.0 build and verified it fixed their problem.
Regression
no. this existed when we checked in the card mark stealing work in 5.0 (which means this only exists in 5.0).